Skip to content

Commit 31386a6

Browse files
Temporarily disable predicated load (#5409)
This PR disables predicated load by default until #5408 is fixed. --------- Signed-off-by: Whitney Tsang <[email protected]> Signed-off-by: Anatoly Myachev <[email protected]> Co-authored-by: Anatoly Myachev <[email protected]>
1 parent 3a1a8c6 commit 31386a6

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

scripts/skiplist/default/triton_kernels.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,3 +71,4 @@ tests/test_matmul.py::test_op[False-True-True-True-False-None-16-1000-704-800-ra
7171
tests/test_matmul.py::test_op[False-True-True-True-False-None-16-1000-704-800-ragged-mxfloat8_e4m3fn-mxfloat4_e2m1-8-2-9-True-None-False-False-False]
7272
tests/test_matmul.py::test_op[False-True-True-True-False-None-16-16-16-1000-batched-float16-float16-5-1-None-False-None-False-False-False]
7373
tests/test_matmul.py::test_op[False-True-True-True-False-None-16-16-16-1000-batched-float8_e5m2-float8_e5m2-5-1-None-False-None-False-False-False]
74+
tests/test_matmul.py::test_op[False-False-False-False-False-None-128-1000-700-700-ragged-float16-float16-8-2-1-False-None-False-False-False]

third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2956,10 +2956,7 @@ struct LoadOpConversion : public ConvertOpToLLVMPattern<triton::LoadOp>,
29562956
Value ret;
29572957
// Create a predicated load operation.
29582958
if (pred) {
2959-
std::optional<bool> enablePredicated =
2960-
mlir::triton::tools::isEnvValueBool(
2961-
mlir::triton::tools::getStrEnv("TRITON_INTEL_PREDICATED"));
2962-
if (!enablePredicated.has_value() || enablePredicated.value())
2959+
if (triton::tools::getBoolEnv("TRITON_INTEL_PREDICATED"))
29632960
ret = rewriter.create<TritonGEN::PredicatedLoadOp>(
29642961
loc, retTy, addrElem, b.i64_val(alignment), pred, other_);
29652962
else {

0 commit comments

Comments
 (0)