[AMD] Cover default case in MfmaGroup (#5218)

makslevental · web-flow · commit 3164a4e2d5a9 · 2024-11-21T15:33:07.000-08:00
If you build using the `CMakeLists.txt` and not `setup.py` and you build
in `Release` then you get

```
/__w/triton/triton/third_party/amd/lib/TritonAMDGPUTransforms/MfmaGroup.cpp: In function ‘std::pair&lt;mlir::Type, mlir::Type&gt; mlir::TypesFromMfmaId(MLIRContext*, MfmaTypeId)’:
Warning: /__w/triton/triton/third_party/amd/lib/TritonAMDGPUTransforms/MfmaGroup.cpp:240:1: warning: control reaches end of non-void function [-Wreturn-type]
```
diff --git a/third_party/amd/lib/TritonAMDGPUTransforms/MfmaGroup.cpp b/third_party/amd/lib/TritonAMDGPUTransforms/MfmaGroup.cpp
@@ -235,8 +235,9 @@ std::pair<mlir::Type, mlir::Type> TypesFromMfmaId(mlir::MLIRContext *ctx,
     return {f8e5m2fnuz, f8e4m3fnuz};
   case MfmaTypeId::Bf8Bf8TyId:
     return {f8e5m2fnuz, f8e5m2fnuz};
+  default:
+    llvm_unreachable("unsupported MfmaTypeId!");
   }
-  assert(false && "unsupported MfmaTypeId");
 }
 
 FailureOr<MfmaInsn> MfmaInsn::selectMfma(unsigned mDim, unsigned nDim,

Original file line number	Diff line number	Diff line change
`@@ -235,8 +235,9 @@ std::pair<mlir::Type, mlir::Type> TypesFromMfmaId(mlir::MLIRContext *ctx,`
`235`	`235`	`return {f8e5m2fnuz, f8e4m3fnuz};`
`236`	`236`	`case MfmaTypeId::Bf8Bf8TyId:`
`237`	`237`	`return {f8e5m2fnuz, f8e5m2fnuz};`
	`238`	`+ default:`
	`239`	`+ llvm_unreachable("unsupported MfmaTypeId!");`
`238`	`240`	`}`
`239`		`- assert(false && "unsupported MfmaTypeId");`
`240`	`241`	`}`
`241`	`242`
`242`	`243`	`FailureOr<MfmaInsn> MfmaInsn::selectMfma(unsigned mDim, unsigned nDim,`