Skip to content

Commit 35b6615

Browse files
committed
Remove subprocess from skiplists
Closes #800 Signed-off-by: Kirill Suvorov <[email protected]>
1 parent f4fdd8f commit 35b6615

File tree

6 files changed

+3
-46
lines changed

6 files changed

+3
-46
lines changed

python/test/unit/language/print_helper.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -131,20 +131,15 @@ def test_print(func: str, data_type: str, device: str):
131131
else:
132132
assert f"Unknown kernel: {func}"
133133

134-
if device == "xpu":
135-
# FIXME: remove trigger to get output from kernel
136-
repr(x)
137-
repr(y)
134+
# Wait until driver complete all the jobs for the device_print, especially test_subprocess
135+
# require this which captures stdout when child exits.
136+
getattr(torch, device).synchronize()
138137

139138
if func != "print_no_arg" and func != "no_arg_print" and func != "device_print_large" and \
140139
func != "print_multiple_args" and func != "device_print_multiple_args" and \
141140
func != "device_print_pointer" and func != "device_print_scalar":
142141
assert_close(y, x)
143142

144-
# Wait until driver complete all the jobs for the device_print, especially test_subprocess
145-
# require this which captures stdout when child exits.
146-
getattr(torch, device).synchronize()
147-
148143

149144
if __name__ == "__main__":
150145
fn = globals()[sys.argv[1]]

scripts/skiplist/a770/subprocess.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.

scripts/skiplist/conda/subprocess.txt

Lines changed: 0 additions & 9 deletions
This file was deleted.

scripts/skiplist/default/subprocess.txt

Lines changed: 0 additions & 9 deletions
This file was deleted.

scripts/skiplist/lts/subprocess.txt

Lines changed: 0 additions & 9 deletions
This file was deleted.

scripts/skiplist/no-basekit/subprocess.txt

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)