Skip to content

Commit 3c189dd

Browse files
authored
[BACKEND][NVIDIA][NFC] Remove BarrierOpConversion conversion as dead code (#5135)
I discovered it while I was looking at triton-lang/triton#5114 (comment). Looks like `bar_id` attribute is no longer used. The attribute setting was removed in: triton-lang/triton@dd2a323. Signed-off-by: Anatoly Myachev <[email protected]>
1 parent 6130c2b commit 3c189dd

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

third_party/nvidia/lib/TritonNVIDIAGPUToLLVM/BarrierOpToLLVM.cpp

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -33,28 +33,6 @@ using namespace mlir;
3333
using namespace mlir::triton;
3434

3535
namespace {
36-
struct BarrierOpConversion
37-
: public ConvertOpToLLVMPattern<mlir::gpu::BarrierOp> {
38-
using ConvertOpToLLVMPattern::ConvertOpToLLVMPattern;
39-
40-
LogicalResult
41-
matchAndRewrite(mlir::gpu::BarrierOp op, OpAdaptor adaptor,
42-
ConversionPatternRewriter &rewriter) const override {
43-
Location loc = op->getLoc();
44-
if (op->hasAttr("bar_id")) {
45-
// llvm.nvvm.barrier0 doesn't support bar_id and num_threads attributes,
46-
// so we have to lower it to ptx manually.
47-
auto barId = op->getAttrOfType<IntegerAttr>("bar_id").getInt();
48-
auto numThreads = op->getAttrOfType<IntegerAttr>("num_threads").getInt();
49-
barSync(rewriter, op, barId, numThreads);
50-
rewriter.eraseOp(op);
51-
return success();
52-
}
53-
// Otherwise we let the default lowering handle it
54-
return failure();
55-
}
56-
};
57-
5836
struct FenceAsyncSharedOpConversion
5937
: public ConvertOpToLLVMPattern<triton::nvidia_gpu::FenceAsyncSharedOp> {
6038
using ConvertOpToLLVMPattern<
@@ -193,7 +171,6 @@ struct WaitBarrierOpConversion
193171
void mlir::triton::NVIDIA::populateBarrierOpToLLVMPatterns(
194172
LLVMTypeConverter &typeConverter, RewritePatternSet &patterns,
195173
PatternBenefit benefit) {
196-
patterns.add<BarrierOpConversion>(typeConverter, benefit);
197174
patterns.add<FenceAsyncSharedOpConversion>(typeConverter, benefit);
198175
patterns.add<InitBarrierOpConversion, InvalBarrierOpConversion>(typeConverter,
199176
benefit);

0 commit comments

Comments
 (0)