Skip to content

Commit 3e95f55

Browse files
authored
[DIALECT] Take out supportReduction (#5997)
Reduction should always be supported by distributed layouts
1 parent 98b957d commit 3e95f55

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

include/triton/Dialect/TritonGPU/IR/TritonGPUAttrDefs.td

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -837,10 +837,6 @@ def MmaEncodingTrait : AttrInterface<"MmaEncodingTrait"> {
837837
let cppNamespace = "::mlir::triton::gpu";
838838
let methods = [
839839

840-
InterfaceMethod<"Return whether the layout support reduction op.",
841-
"bool",
842-
"supportReduction">,
843-
844840
InterfaceMethod<"Return size per thread for dot operands.",
845841
"SmallVector<unsigned>",
846842
"getSizePerThreadForOperand",
@@ -971,9 +967,6 @@ V [ 0,4,8...60 1,5...61 2,6...62 3,7...63 ] [ 128,132...188 129,
971967
);
972968

973969
let extraClassDeclaration = extraDistributedDeclaration # [{
974-
bool supportReduction() const {
975-
return true;
976-
}
977970
SmallVector<unsigned> getSizePerThreadForOperand(int kWidth, int opIdx) const;
978971
SmallVector<int64_t> getInstrShapeForOperand(int kWidth, int opIdx) const;
979972
SmallVector<int64_t> getRepForOperand(ArrayRef<int64_t> operandShape, int kWidth, int opIdx) const;
@@ -1100,9 +1093,6 @@ Row |
11001093
let hasCustomAssemblyFormat = 1;
11011094

11021095
let extraClassDeclaration = extraDistributedDeclaration # [{
1103-
bool supportReduction() const {
1104-
return true;
1105-
}
11061096
SmallVector<unsigned> getSizePerThreadForOperand(int kWidth, int opIdx) const;
11071097
SmallVector<int64_t> getElemsPerInstrForOperands() const;
11081098
SmallVector<int64_t> getRepForOperand(ArrayRef<int64_t> operandShape,
@@ -1228,13 +1218,6 @@ For example, the matrix L corresponding to blockTileSize=[32,16] is:
12281218
int opIdx) const;
12291219
SmallVector<unsigned> getRepOrderForOperand(int opIdx) const;
12301220
SmallVector<unsigned> getThreadsPerWarpForOperand(int opIdx) const;
1231-
1232-
bool supportReduction() const {
1233-
if (isAmpere() || isHopper()) {
1234-
return true;
1235-
}
1236-
return false;
1237-
};
12381221
SmallVector<unsigned> getSizePerThreadForOperand(int kWidth, int opIdx) const;
12391222

12401223
SmallVector<unsigned> getContigPerThread() {

0 commit comments

Comments
 (0)