Skip to content

Commit 43fbabb

Browse files
authored
Use more xfail calls instead of skip calls in test_matmul.py (#5103)
Pass rate 98.11% -> 98.65% Signed-off-by: Anatoly Myachev <[email protected]>
1 parent 904f124 commit 43fbabb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

python/triton_kernels/tests/test_matmul.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ def test_set_idle_sms():
562562
def test_fused_act(m, n, k, mode, split_k, do_gather, do_scatter, fused_scatter, is_persistent, epilogue_subtile,
563563
swiglu_alpha, swiglu_limit, device, opt_flags_scope):
564564
if fused_scatter and split_k > 1:
565-
pytest.skip("fused scatter scratchpad not supported with split_k")
565+
pytest.xfail("fused scatter scratchpad not supported with split_k")
566566
torch.manual_seed(0)
567567
constraints = {
568568
"is_persistent": is_persistent,
@@ -595,7 +595,7 @@ def test_fused_act(m, n, k, mode, split_k, do_gather, do_scatter, fused_scatter,
595595
fused_activation=FusedActivation(FnSpecs("swiglu", swiglu_fn, ("alpha", "limit")),
596596
(swiglu_alpha, swiglu_limit), 2))
597597
except opt_flags.InapplicableConstraint:
598-
pytest.skip("inapplicable constraint")
598+
pytest.xfail("inapplicable constraint")
599599

600600
assert_close(a, b)
601601

@@ -619,7 +619,7 @@ def test_zero_reduction_dim(m, n, k, view_x_as_zero_cols, device):
619619
try:
620620
tri_y = matmul_ogs(x, w, bias)
621621
except opt_flags.InapplicableConstraint:
622-
pytest.skip("inapplicable constraint")
622+
pytest.xfail("inapplicable constraint")
623623
ref_y = matmul_ogs_torch(x, w, bias, round_x=lambda x, idx: x, round_y=lambda y: y, device=device)
624624

625625
assert_close(ref_y, tri_y)

0 commit comments

Comments
 (0)