You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix issue found by @anmyachev at
triton-lang/triton#7439
> Should it be like: `_PyFloat_Pack2(f, (unsigned char *)&result, 1);`?
(this is how it is implemented in
https://github.com/python/pythoncapi-compat/blob/b541b98df1e3e5aabb5def27422a75c876f5a88a/pythoncapi_compat.h#L488)
>
> I see the following issue with current approach:
>
> ```shell
> python/test/unit/language/test_annotations.py
/tmp/tmp9qfrehja/main.cpp:148:5: error: no matching function for call to
'_PyFloat_Pack2'
> 148 | _PyFloat_Pack2(f, (void*)&result, 1);
> | ^~~~~~~~~~~~~~
> /home/jovyan/.conda/envs/xpu/include/python3.10/floatobject.h:87:17:
note: candidate function not viable: cannot convert argument of
incomplete type 'void *' to
> 'unsigned char *' for 2nd argument
> 87 | PyAPI_FUNC(int) _PyFloat_Pack2(double x, unsigned char *p, int
le);
> | ^ ~~~~~~~~~~~~~~~~
> 1 error generated.
> ```
0 commit comments