Skip to content

Commit 4689755

Browse files
committed
Fix coverity issues
Signed-off-by: Anatoly Myachev <[email protected]>
1 parent bbba43a commit 4689755

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

lib/Analysis/AxisInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,7 @@ class ShLIOpAxisInfoVisitor final : public BinaryOpVisitorImpl<arith::ShLIOp> {
895895
lhsDivisibility = 1;
896896
}
897897
auto numBits = log2Int(lhsDivisibility);
898-
return multiplyDivisor(lhsDivisibility, 1 << shift);
898+
return multiplyDivisor(lhsDivisibility, static_cast<int64_t>(1) << shift);
899899
}
900900

901901
int64_t getConstancy(arith::ShLIOp op, const AxisInfo &lhs,

lib/Conversion/TritonGPUToLLVM/ScanOpToLLVM.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ static void AddPartialReduce(SmallVector<SmallVector<Value>> &srcValues,
128128
ConversionPatternRewriter &rewriter,
129129
const TargetInfoBase &targetInfo,
130130
ScanLoweringHelper &helper,
131-
SmallVector<Value> smemBases,
132-
SmallVector<Type> smemTypes, Value warpId,
131+
const SmallVector<Value> &smemBases,
132+
const SmallVector<Type> &smemTypes, Value warpId,
133133
Value laneIdAxis, Value parallelLaneId) {
134134
Location loc = helper.getLoc();
135135
unsigned numParallelLane = helper.getNonAxisNumThreadsPerCTA();

third_party/intel/lib/Analysis/AxisInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -900,7 +900,7 @@ class ShLIOpAxisInfoVisitor final : public BinaryOpVisitorImpl<arith::ShLIOp> {
900900
lhsDivisibility = 1;
901901
}
902902
auto numBits = log2Int(lhsDivisibility);
903-
return multiplyDivisor(lhsDivisibility, 1 << shift);
903+
return multiplyDivisor(lhsDivisibility, static_cast<int64_t>(1) << shift);
904904
}
905905

906906
int64_t getConstancy(arith::ShLIOp op, const AxisInfo &lhs,

third_party/intel/lib/TritonIntelGPUToLLVM/ScanOpToLLVM.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ static void AddPartialReduce(SmallVector<SmallVector<Value>> &srcValues,
126126
ConversionPatternRewriter &rewriter,
127127
const TargetInfoBase &targetInfo,
128128
ScanLoweringHelper &helper,
129-
SmallVector<Value> smemBases,
130-
SmallVector<Type> smemTypes, Value warpId,
129+
const SmallVector<Value> &smemBases,
130+
const SmallVector<Type> &smemTypes, Value warpId,
131131
Value laneIdAxis, Value parallelLaneId) {
132132
Location loc = helper.getLoc();
133133
unsigned numParallelLane = helper.getNonAxisNumThreadsPerCTA();

third_party/intel/lib/TritonIntelGPUTransforms/Coalesce.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ struct CoalescePass
4040
llvm::dbgs() << "\n";
4141
});
4242

43-
auto contiguity = axisInfoAnalysis.getAxisInfo(ptr)->getContiguity();
43+
const auto &contiguity = axisInfoAnalysis.getAxisInfo(ptr)->getContiguity();
4444
SmallVector<unsigned> order = argSort(contiguity);
4545
LDBG("order=[" << triton::join(order, ", ") << "]");
4646

0 commit comments

Comments
 (0)