Skip to content

Commit 468bec4

Browse files
[UT] Enable overflow check (#2656)
Signed-off-by: Whitney Tsang <[email protected]>
1 parent eadfd79 commit 468bec4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

include/triton/Dialect/Triton/IR/TritonOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ def TT_AssertOp : TT_Op<"assert", [MemoryEffects<[MemWrite<GlobalMemory>]>]> {
893893
`tt.assert` takes a condition tensor and a message string.
894894
If the condition is false, the message is printed, and the program is aborted.
895895
}];
896-
let arguments = (ins TT_Tensor:$condition, StrAttr:$message);
896+
let arguments = (ins AnyTypeOf<[I1, I1Tensor]>:$condition, StrAttr:$message);
897897
let assemblyFormat = "$condition `,` $message attr-dict `:` type($condition)";
898898
}
899899

python/test/unit/language/test_core.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2595,8 +2595,8 @@ def kernel(X, Y, N, BLOCK_M: tl.constexpr, BLOCK_N: tl.constexpr, NUM_PID_N: tl.
25952595
@pytest.mark.parametrize("axis", [0, 1])
25962596
@pytest.mark.parametrize("add_overflow_check", [False, True])
25972597
def test_scan_layouts(M, N, src_layout, axis, add_overflow_check, device, tmp_path: pathlib.Path):
2598-
if add_overflow_check is True and (is_hip() or is_xpu()):
2599-
pytest.skip("overflow check disabled on HIP/XPU while fixing issues")
2598+
if add_overflow_check is True and is_hip():
2599+
pytest.skip("overflow check disabled on HIP while fixing issues")
26002600

26012601
overflow_check = """
26022602
%17 = arith.extsi %arg2 : i32 to i64
@@ -2689,8 +2689,8 @@ def test_reduce_layouts(M, N, src_layout, axis, epilogue_kind, dtype_str, add_ov
26892689
pytest.skip("Skipping because tensor shape is smaller than M(f)maLayout instr_shape")
26902690
if is_hip() and isinstance(src_layout, MfmaLayout) and ((M, N) == (128, 128)):
26912691
pytest.skip("Skipping test because it runs out of shared memory")
2692-
if add_overflow_check is True and (is_hip() or is_xpu()):
2693-
pytest.skip("overflow check disabled on HIP/XPU while fixing issues")
2692+
if add_overflow_check is True and is_hip():
2693+
pytest.skip("overflow check disabled on HIP while fixing issues")
26942694
if reduce_op == "sum" and dtype_str == "float16" and M * N > 1024:
26952695
pytest.xfail("Skipping sum reduction on float16 due to accuracy issues")
26962696

0 commit comments

Comments
 (0)