Skip to content

Commit 46d8237

Browse files
Fix build and test failures from 3e30ae6
Signed-off-by: Whitney Tsang <[email protected]>
1 parent 8a781ae commit 46d8237

File tree

2 files changed

+5
-30
lines changed

2 files changed

+5
-30
lines changed

third_party/intel/lib/Dialect/TritonIntelGPU/IR/Dialect.cpp

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -135,21 +135,6 @@ SmallVector<unsigned> DpasEncodingAttr::getShapeC() const {
135135
return resShape;
136136
}
137137

138-
SmallVector<unsigned> DpasEncodingAttr::getDefaultOrder() const {
139-
auto rank = getWarpsPerCTA().size();
140-
return getMatrixOrder(rank, /*rowMajor*/ true);
141-
}
142-
143-
SmallVector<unsigned> DpasEncodingAttr::getDefaultThreadOrder() const {
144-
auto rank = getWarpsPerCTA().size();
145-
return getMatrixOrder(rank, /*rowMajor*/ true);
146-
}
147-
148-
SmallVector<unsigned> DpasEncodingAttr::getDefaultWarpOrder() const {
149-
auto rank = getWarpsPerCTA().size();
150-
return getMatrixOrder(rank, /*rowMajor*/ true);
151-
}
152-
153138
SmallVector<unsigned> DpasEncodingAttr::getRepOrder() const {
154139
auto rank = getWarpsPerCTA().size();
155140
return getMatrixOrder(rank, /*rowMajor*/ true);
@@ -459,18 +444,6 @@ LinearLayout WarpEncodingAttr::toLinearLayout(ArrayRef<int64_t> shape) const {
459444
llvm::report_fatal_error("NYI. WarpEncodingAttr::toLinearLayout");
460445
}
461446

462-
SmallVector<unsigned> WarpEncodingAttr::getDefaultOrder() const {
463-
llvm::report_fatal_error("NYI. WarpEncodingAttr::getDefaultOrder");
464-
}
465-
466-
SmallVector<unsigned> WarpEncodingAttr::getDefaultThreadOrder() const {
467-
llvm::report_fatal_error("NYI. WarpEncodingAttr::getDefaultThreadOrder");
468-
}
469-
470-
SmallVector<unsigned> WarpEncodingAttr::getDefaultWarpOrder() const {
471-
llvm::report_fatal_error("NYI. WarpEncodingAttr::getDefaultWarpOrder");
472-
}
473-
474447
SmallVector<unsigned> WarpEncodingAttr::getCTAsPerCGA() const {
475448
llvm::report_fatal_error("NYI. WarpEncodingAttr::getCTAsPerCGA");
476449
}

third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -556,7 +556,8 @@ struct LoadOpToBlockIOConversion
556556
SmallVector<int64_t> numReps =
557557
dpasLayout.getDPASRepetitions(tensorShape, opIdx);
558558
const SmallVector<unsigned> warpsPerCTA = dpasLayout.getWarpsPerCTA();
559-
SmallVector<unsigned> dpasWarpsOrder = triton::gpu::getOrder(tensorType);
559+
SmallVector<unsigned> dpasWarpsOrder =
560+
getMatrixOrder(warpsPerCTA.size(), /*rowMajor*/ true);
560561
unsigned threadsPerWarp =
561562
product<unsigned>(getThreadsPerWarp(dpasLayout, tensorShape));
562563

@@ -1047,7 +1048,7 @@ struct LoadOpConversion
10471048
dpasLayout.getDPASRepetitions(tensorShape, opIdx);
10481049
const SmallVector<unsigned> warpsPerCTA = dpasLayout.getWarpsPerCTA();
10491050
SmallVector<unsigned> dpasWarpsOrder =
1050-
triton::gpu::getWarpOrder(tensorType);
1051+
getMatrixOrder(warpsPerCTA.size(), /*rowMajor*/ true);
10511052
unsigned threadsPerWarp =
10521053
product<unsigned>(getThreadsPerWarp(dpasLayout, tensorShape));
10531054

@@ -1680,7 +1681,8 @@ struct StoreOpConversion
16801681
const SmallVector<unsigned> warpsPerCTA = dpasLayout.getWarpsPerCTA();
16811682
SmallVector<int64_t> numReps =
16821683
dpasLayout.getDPASRepetitions(tensorShape, 2);
1683-
SmallVector<unsigned> dpasWarpsOrder = triton::gpu::getOrder(tensorType);
1684+
SmallVector<unsigned> dpasWarpsOrder =
1685+
getMatrixOrder(warpsPerCTA.size(), /*rowMajor*/ true);
16841686
unsigned threadsPerWarp =
16851687
product<unsigned>(getThreadsPerWarp(dpasLayout, tensorShape));
16861688

0 commit comments

Comments
 (0)