Skip to content

Commit 4ddebd2

Browse files
authored
[NFC] Remove duplicated call to function mlir_check_link_libraries (#4954)
The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. - [ ] I am not making a trivial change, such as fixing a typo in a comment. - [ ] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [x] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [ x] This PR does not need a test because `it is a non functional change that simply removes duplicated call to a cmake function`. - Select one of the following. - [x] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.)
1 parent 76ed94d commit 4ddebd2

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

bin/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ target_link_libraries(triton-reduce PRIVATE
5050
mlir_check_all_link_libraries(triton-reduce)
5151

5252
add_llvm_executable(triton-lsp triton-lsp.cpp PARTIAL_SOURCES_INTENDED)
53-
mlir_check_all_link_libraries(triton-lsp)
5453

5554
llvm_update_compile_flags(triton-lsp)
5655
target_link_libraries(triton-lsp PRIVATE

0 commit comments

Comments
 (0)