Skip to content

Commit 56a3094

Browse files
committed
move launch benchmark to third party and add csv parsing
1 parent 96114b9 commit 56a3094

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

.github/workflows/third-party-benchmarks.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,18 @@ jobs:
223223
--max-new-tokens $MAX_NEW_TOKENS \
224224
--batch-size $BATCH_SIZE
225225
226+
- name: Run launch microbenchmark tests
227+
if: ${{ steps.install.outcome == 'success' && !cancelled() && (inputs.benchmarks == '' || contains(fromJson(inputs.benchmarks || '[]'), 'launch_micro_benchmarks')) && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'launch_micro_benchmarks') }}
228+
run: |
229+
source scripts/capture-hw-details.sh
230+
python python/test/microbenchmark/launch_overhead.py --reports $REPORTS
231+
232+
python benchmarks/third_party/vllm/transform_results.py $REPORTS/launch_overhead_results.csv $REPORTS/launch_overhead-report.csv \
233+
--tag $TAG \
234+
--bgroup overhead \
235+
--benchmark launch-overhead \
236+
--param_cols="input_type"
237+
226238
- name: Upload benchmark reports
227239
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
228240
uses: actions/upload-artifact@v5

.github/workflows/triton-benchmarks.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -376,12 +376,6 @@ jobs:
376376
cd benchmarks/micro_benchmarks
377377
python run_benchmarks.py --reports $REPORTS
378378
379-
- name: Run launch microbenchmark tests
380-
if: ${{ steps.install.outcome == 'success' && !cancelled() && (inputs.benchmarks == '' || contains(fromJson(inputs.benchmarks || '[]'), 'launch_micro_benchmarks')) && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'launch_micro_benchmarks') }}
381-
run: |
382-
source scripts/capture-hw-details.sh
383-
python python/test/microbenchmark/launch_overhead.py
384-
385379
- name: Upload benchmark reports
386380
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
387381
uses: actions/upload-artifact@v5

benchmarks/third_party/vllm/transform_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def serialize_params(row):
4646

4747
dfs = []
4848
for compiler_name in compilers:
49-
for value_name in ['TFlops', 'GB/s']:
49+
for value_name in ['TFlops', 'GB/s', 'time_us']:
5050
col = f'{compiler_name}-{value_name}'
5151
if col not in df.columns:
5252
continue

python/test/microbenchmark/launch_overhead.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,13 @@ def main(use_tensor_desc: bool, reports_dir: str = None):
9999

100100
if reports_dir:
101101
os.makedirs(reports_dir, exist_ok=True)
102-
csv_path = os.path.join(reports_dir, "launch_overhead_report.csv")
102+
csv_path = os.path.join(reports_dir, "launch_overhead_results.csv")
103103
file_exists = os.path.exists(csv_path)
104104

105105
with open(csv_path, "a", newline="") as csvfile:
106106
writer = csv.writer(csvfile)
107107
if not file_exists:
108-
writer.writerow(["input_type", "median_usecs"])
108+
writer.writerow(["input_type", "triton-time_us"])
109109

110110
input_type = "TensorDescriptor" if use_tensor_desc else "Tensor"
111111
writer.writerow([input_type, round(sorted(usecs)[len(usecs) >> 1], 2)])

0 commit comments

Comments
 (0)