Skip to content

Commit 59e291d

Browse files
[Intel] Remove DecomposeUnsupportedConversions (#3734)
This is to prepare for upstream commit triton-lang/triton@dd6a540. Signed-off-by: Whitney Tsang <[email protected]>
1 parent 47b0c0e commit 59e291d

File tree

6 files changed

+0
-83
lines changed

6 files changed

+0
-83
lines changed

test/TritonIntelGPU/tritonintlgpu-decompose-unsupported-cvt-layout.mlir

Lines changed: 0 additions & 44 deletions
This file was deleted.

third_party/intel/backend/compiler.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -332,10 +332,6 @@ def make_llir(src, metadata, options):
332332
srcMgr = llvm.source_mgr()
333333
ir.source_mgr_diag(srcMgr, mod.context)
334334
mod.context.printOpOnDiagnostic(True)
335-
# FIXME: Advanced path drops tensor layouts, so this will crash on some
336-
# operations being used, e.g., convert_layout.
337-
if os.getenv("TRITON_INTEL_REDUCE_TRANSPOSE", "0") != "1":
338-
intel.passes.ttgpuir.add_decompose_unsupported_conversions(pm)
339335
passes.convert.add_scf_to_cf(pm)
340336
passes.convert.add_index_to_llvmir(pm)
341337
# FIXME: Advanced path uses custom type conversion and needs hacky

third_party/intel/include/TritonIntelGPUToLLVM/Passes.td

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33

44
include "mlir/Pass/PassBase.td"
55

6-
def IntelDecomposeUnsupportedConversions
7-
: Pass<"intel-decompose-unsupported-conversions", "mlir::ModuleOp"> {
8-
let summary = "Decompose conversions that are not supported by TritonGPU -> LLVM";
9-
}
10-
116
def ConvertTritonIntelGPUToLLVM
127
: Pass<"convert-triton-intel-gpu-to-llvm", "mlir::ModuleOp"> {
138
let summary = "Convert TritonIntelGPU to LLVM";

third_party/intel/lib/TritonIntelGPUToLLVM/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ add_triton_library(TritonIntelGPUToLLVM
33
BF16Casts.cpp
44
ControlFlowOpToLLVM.cpp
55
ConvertLayoutOpToLLVM.cpp
6-
DecomposeUnsupportedConversions.cpp
76
DotOpToLLVM/DPAS.cpp
87
DotOpToLLVM/FMA.cpp
98
DotOpToLLVM.cpp

third_party/intel/lib/TritonIntelGPUToLLVM/DecomposeUnsupportedConversions.cpp

Lines changed: 0 additions & 27 deletions
This file was deleted.

third_party/intel/triton_xpu.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ void init_triton_intel_passes_ttgpuir(py::module &&m) {
8181
gpu::intel::createTritonIntelGPUAccelerateMatmul);
8282
ADD_PASS_WRAPPER_0("add_rewrite_stack_ptr",
8383
gpu::intel::createTritonIntelGPURewriteStackPtr);
84-
ADD_PASS_WRAPPER_0("add_decompose_unsupported_conversions",
85-
gpu::intel::createIntelDecomposeUnsupportedConversions);
8684
ADD_PASS_WRAPPER_OPT_2("add_pipeline",
8785
gpu::intel::createTritonIntelGPUPipeline, int, bool);
8886
ADD_PASS_WRAPPER_0("add_remove_layout_conversions",

0 commit comments

Comments
 (0)