Skip to content

Commit 5d61262

Browse files
dev-tomekdev-tomek
authored
[Skiplists] Reduce the length of the skiplists with regex (#5237)
Addressing #5108, this PR introduces skiplist reductions with the use of new features in the pytest-skip plugin. It was possible to significantly reduce the lengths for most of the skiplists, however there are still certain groups of test cases that remained untouched due to regex pattern creation complexity. Technically, all lists can be matched with a single pattern, however this comes at a trade-off of the pattern readibility. The number of skips for the tests affected, was manually checked whether it alignes with the main branch without the regex patterns and no additional tests are skipped. Below is the summary: <img width="600" height="600" alt="image" src="https://github.com/user-attachments/assets/2c892188-ed8d-4ad8-8c19-d0af0d1682ee" />
1 parent b5c46f0 commit 5d61262

File tree

12 files changed

+102
-1921
lines changed

12 files changed

+102
-1921
lines changed

‎scripts/skiplist/a770/debug.txt‎

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,6 @@
11
# https://github.com/intel/intel-xpu-backend-for-triton/issues/2755
2-
python/test/unit/test_debug.py::test_device_assert[False-False-True-None-False]
3-
python/test/unit/test_debug.py::test_device_assert[False-False-True-True-False]
4-
python/test/unit/test_debug.py::test_device_assert[False-True-False-None-False]
5-
python/test/unit/test_debug.py::test_device_assert[False-True-False-True-False]
6-
python/test/unit/test_debug.py::test_device_assert[False-True-None-None-False]
7-
python/test/unit/test_debug.py::test_device_assert[False-True-None-True-False]
8-
python/test/unit/test_debug.py::test_device_assert[False-True-True-None-False]
9-
python/test/unit/test_debug.py::test_device_assert[False-True-True-True-False]
10-
python/test/unit/test_debug.py::test_device_assert[True-False-None-None-False]
11-
python/test/unit/test_debug.py::test_device_assert[True-False-None-True-False]
12-
python/test/unit/test_debug.py::test_device_assert[True-False-True-None-False]
13-
python/test/unit/test_debug.py::test_device_assert[True-False-True-True-False]
14-
python/test/unit/test_debug.py::test_device_assert[True-True-False-None-False]
15-
python/test/unit/test_debug.py::test_device_assert[True-True-False-True-False]
16-
python/test/unit/test_debug.py::test_device_assert[True-True-None-None-False]
17-
python/test/unit/test_debug.py::test_device_assert[True-True-None-True-False]
18-
python/test/unit/test_debug.py::test_device_assert[True-True-True-None-False]
19-
python/test/unit/test_debug.py::test_device_assert[True-True-True-True-False]
20-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[-2147483648--1-int32-int32-True-True]
21-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[2147483647-1-int32-int32-True-True]
22-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[2147483647-100-int32-int32-True-True]
23-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[-32768--1-int16-int16-True-True]
24-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[32767-1-int16-int16-True-True]
25-
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[-1073741824--4-int32-int32-True-True]
26-
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[1073741824-2-int32-int32-True-True]
27-
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[1073741824-4-int32-int32-True-True]
2+
python/test/unit/test_debug.py::test_device_assert[r"^(False|True)-(False|True)-True-(True|None)-False$|^(False|True)-True-None-(True|None)-False$|^(False|True)-True-False-(True|None)-False$|^True-False-None-(True|None)-False$"]@regexp
3+
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[r".*True-True$"]@regexp
4+
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[r".*True-True$"]@regexp
285
python/test/unit/test_debug.py::test_sanitize_int_sub_overflow[2147483647--1-int32-int32-True-True]
296
python/test/unit/test_debug.py::test_sanitize_int_sub_overflow[-2147483648-1-int32-int32-True-True]

‎scripts/skiplist/a770/language.txt‎

Lines changed: 33 additions & 559 deletions
Large diffs are not rendered by default.

‎scripts/skiplist/arl-h/debug.txt‎

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,6 @@
11
# https://github.com/intel/intel-xpu-backend-for-triton/issues/2755
2-
python/test/unit/test_debug.py::test_device_assert[False-False-True-None-False]
3-
python/test/unit/test_debug.py::test_device_assert[False-False-True-True-False]
4-
python/test/unit/test_debug.py::test_device_assert[False-True-False-None-False]
5-
python/test/unit/test_debug.py::test_device_assert[False-True-False-True-False]
6-
python/test/unit/test_debug.py::test_device_assert[False-True-None-None-False]
7-
python/test/unit/test_debug.py::test_device_assert[False-True-None-True-False]
8-
python/test/unit/test_debug.py::test_device_assert[False-True-True-None-False]
9-
python/test/unit/test_debug.py::test_device_assert[False-True-True-True-False]
10-
python/test/unit/test_debug.py::test_device_assert[True-False-None-None-False]
11-
python/test/unit/test_debug.py::test_device_assert[True-False-None-True-False]
12-
python/test/unit/test_debug.py::test_device_assert[True-False-True-None-False]
13-
python/test/unit/test_debug.py::test_device_assert[True-False-True-True-False]
14-
python/test/unit/test_debug.py::test_device_assert[True-True-False-None-False]
15-
python/test/unit/test_debug.py::test_device_assert[True-True-False-True-False]
16-
python/test/unit/test_debug.py::test_device_assert[True-True-None-None-False]
17-
python/test/unit/test_debug.py::test_device_assert[True-True-None-True-False]
18-
python/test/unit/test_debug.py::test_device_assert[True-True-True-None-False]
19-
python/test/unit/test_debug.py::test_device_assert[True-True-True-True-False]
20-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[-2147483648--1-int32-int32-True-True]
21-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[2147483647-1-int32-int32-True-True]
22-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[2147483647-100-int32-int32-True-True]
23-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[-32768--1-int16-int16-True-True]
24-
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[32767-1-int16-int16-True-True]
25-
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[-1073741824--4-int32-int32-True-True]
26-
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[1073741824-2-int32-int32-True-True]
27-
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[1073741824-4-int32-int32-True-True]
2+
python/test/unit/test_debug.py::test_device_assert[r"^(False|True)-(False|True)-True-(True|None)-False$|^(False|True)-True-None-(True|None)-False$|^(False|True)-True-False-(True|None)-False$|^True-False-None-(True|None)-False$"]@regexp
3+
python/test/unit/test_debug.py::test_sanitize_int_add_overflow[r".*True-True$"]@regexp
4+
python/test/unit/test_debug.py::test_sanitize_int_mul_overflow[r".*True-True$"]@regexp
285
python/test/unit/test_debug.py::test_sanitize_int_sub_overflow[2147483647--1-int32-int32-True-True]
296
python/test/unit/test_debug.py::test_sanitize_int_sub_overflow[-2147483648-1-int32-int32-True-True]

0 commit comments

Comments
 (0)