Skip to content

Commit 6000ece

Browse files
authored
[CI][sglang] Fixed sglang testing, added pin, updated patch (#5376)
1. Adds sglang pin 2. Updates patch, current patch is broken 3. Unifies sglang testing with the rest of third-party testing Closes #5375
1 parent 553e972 commit 6000ece

File tree

5 files changed

+323
-157
lines changed

5 files changed

+323
-157
lines changed

.github/workflows/sglang-tests.yml

Lines changed: 0 additions & 100 deletions
This file was deleted.

.github/workflows/third-party-tests.yml

Lines changed: 64 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Third party tests [liger-kernels, vllm]
1+
name: Third party tests [liger-kernels, vllm, sglang]
22

33
on:
44
workflow_dispatch:
@@ -28,12 +28,12 @@ env:
2828
TAG: ${{ inputs.tag || (github.event_name == 'pull_request' && format('pr-{0}', github.event.number)) || (github.event_name == 'schedule' && 'ci') || 'test' }}
2929

3030
jobs:
31-
build:
32-
name: Third party tests [liger-kernels, vllm]
31+
small-tests:
32+
name: Third party tests [vllm, sglang]
3333
runs-on:
3434
- linux
3535
- ${{ inputs.runner_label || 'max1550' }}
36-
timeout-minutes: 720
36+
timeout-minutes: 120
3737
defaults:
3838
run:
3939
shell: bash -noprofile --norc -eo pipefail -c "source /opt/intel/oneapi/setvars.sh > /dev/null; source {0}"
@@ -47,14 +47,7 @@ jobs:
4747
- name: Checkout repository
4848
uses: actions/checkout@v5
4949

50-
- name: Install Python
51-
if: ${{ !(inputs.use_pyenv_python || false) }}
52-
uses: actions/setup-python@v6
53-
with:
54-
python-version: ${{ env.PYTHON_VERSION }}
55-
5650
- name: Install Python (from pyenv) ${{ inputs.python_version }}
57-
if: ${{ inputs.use_pyenv_python }}
5851
uses: ./.github/actions/setup-pyenv-python
5952
with:
6053
python-version: ${{ env.PYTHON_VERSION }}
@@ -71,34 +64,84 @@ jobs:
7164
- name: Setup PyTorch
7265
uses: ./.github/actions/setup-pytorch
7366

74-
- name: Build Triton wheels
75-
uses: ./.github/actions/setup-triton
76-
with:
77-
command: DEBUG=1 python -m build --wheel --no-isolation
78-
79-
- name: Install Triton
67+
- name: Setup Triton
8068
id: install
81-
run: |
82-
pip install dist/*.whl
69+
uses: ./.github/actions/setup-triton
8370

8471
- name: Create reports dir
8572
run: |
8673
mkdir reports
8774
echo "REPORTS=$PWD/reports" >> $GITHUB_ENV
8875
76+
- name: Run SGLANG tests
77+
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
78+
run: |
79+
./scripts/test-triton.sh --sglang --skip-pip-install --skip-pytorch-install
80+
8981
- name: Run VLLM tests
9082
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
9183
run: |
9284
./scripts/test-triton.sh --vllm --skip-pip-install --skip-pytorch-install
9385
94-
- name: Run Liger-Kernel tests
86+
- name: Upload test report
9587
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
88+
uses: actions/upload-artifact@v4
89+
with:
90+
name: test-main-reports
91+
path: reports
92+
# We run all tests for Liger, so it's slow and we test it separately
93+
liger:
94+
name: Liger testing
95+
runs-on:
96+
- linux
97+
- ${{ inputs.runner_label || 'max1550' }}
98+
timeout-minutes: 120
99+
defaults:
100+
run:
101+
shell: bash -noprofile --norc -eo pipefail -c "source /opt/intel/oneapi/setvars.sh > /dev/null; source {0}"
102+
steps:
103+
- name: Print inputs
104+
run: |
105+
cat <<EOF
106+
${{ toJSON(inputs) }}
107+
EOF
108+
109+
- name: Checkout repository
110+
uses: actions/checkout@v5
111+
112+
- name: Install Python (from pyenv) ${{ inputs.python_version }}
113+
uses: ./.github/actions/setup-pyenv-python
114+
with:
115+
python-version: ${{ env.PYTHON_VERSION }}
116+
117+
- name: Identify Python version
118+
run: |
119+
PYTHON_VERSION="$(python -c 'import sys; print(f"{sys.version_info[0]}.{ sys.version_info[1]}")')"
120+
echo "PYTHON_VERSION=$PYTHON_VERSION" | tee -a $GITHUB_ENV
121+
122+
- name: Install Python build dependencies
123+
run: |
124+
pip install cmake
125+
126+
- name: Setup PyTorch
127+
uses: ./.github/actions/setup-pytorch
128+
129+
- name: Setup Triton
130+
id: install
131+
uses: ./.github/actions/setup-triton
132+
133+
- name: Create reports dir
134+
run: |
135+
mkdir reports
136+
echo "REPORTS=$PWD/reports" >> $GITHUB_ENV
137+
138+
- name: Run Liger-Kernel tests
96139
run: |
97140
./scripts/test-triton.sh --liger --skip-pip-install --skip-pytorch-install
98141
99142
- name: Upload test report
100143
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
101144
uses: actions/upload-artifact@v4
102145
with:
103-
name: test-reports
146+
name: test-liger-reports
104147
path: reports

0 commit comments

Comments
 (0)