Skip to content

Commit 696dadf

Browse files
authored
Update inductor_xpu_test.sh: don't add --freezing in reference mode; add new mode: inference-with-freezing (#4479)
I noticed because (although I'm not sure if that's root cause): ```bash # works python benchmarks/dynamo/torchbench.py --accuracy --float32 -d xpu -n10 --inference --only detectron2_maskrcnn_r_50_c4 --backend=inductor --cold-start-latency --------- Signed-off-by: Anatoly Myachev <[email protected]>
1 parent 2e51a74 commit 696dadf

File tree

6 files changed

+16
-14
lines changed

6 files changed

+16
-14
lines changed

.github/workflows/e2e-accuracy.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ on:
1818
- torchbench
1919
default: all
2020
mode:
21-
description: Inference, inference-no-freezing, or training
21+
description: Inference, inference-with-freezing, or training
2222
type: choice
2323
options:
2424
- all
2525
- inference
26-
- inference-no-freezing
26+
- inference-with-freezing
2727
- training
2828
default: all
2929
dtype:
@@ -86,7 +86,7 @@ jobs:
8686
suite='["${{ inputs.suite }}"]'
8787
fi
8888
if [[ -z "${{ inputs.mode }}" || "${{ inputs.mode }}" == "all" ]]; then
89-
mode='["inference", "inference-no-freezing", "training"]'
89+
mode='["inference", "inference-with-freezing", "training"]'
9090
else
9191
mode='["${{ inputs.mode }}"]'
9292
fi

.github/workflows/e2e-performance.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ on:
1818
- torchbench
1919
default: all
2020
mode:
21-
description: Inference, inference-no-freezing, or training
21+
description: Inference, inference-with-freezing, or training
2222
type: choice
2323
options:
2424
- all
2525
- inference
26-
- inference-no-freezing
26+
- inference-with-freezing
2727
- training
2828
default: all
2929
dtype:
@@ -87,7 +87,7 @@ jobs:
8787
suite='["${{ inputs.suite }}"]'
8888
fi
8989
if [[ -z "${{ inputs.mode }}" || "${{ inputs.mode }}" == "all" ]]; then
90-
mode='["inference", "inference-no-freezing", "training"]'
90+
mode='["inference", "inference-with-freezing", "training"]'
9191
else
9292
mode='["${{ inputs.mode }}"]'
9393
fi

.github/workflows/e2e-reusable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ on:
1212
type: string
1313
default: all
1414
mode:
15-
description: Inference, inference-no-freezing, or training
15+
description: Inference, inference-with-freezing, or training
1616
type: string
1717
default: all
1818
test_mode:

.github/workflows/e2e-windows.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ on:
1414
- torchbench
1515
default: all
1616
mode:
17-
description: Inference, inference-no-freezing, or training
17+
description: Inference, inference-with-freezing, or training
1818
type: choice
1919
options:
2020
- all
2121
- inference
22-
- inference-no-freezing
22+
- inference-with-freezing
2323
- training
2424
default: all
2525
dtype:
@@ -90,7 +90,7 @@ jobs:
9090
suite='["${{ inputs.suite }}"]'
9191
fi
9292
if [[ -z "${{ inputs.mode }}" || "${{ inputs.mode }}" == "all" ]]; then
93-
mode='["inference", "inference-no-freezing", "training"]'
93+
mode='["inference", "inference-with-freezing", "training"]'
9494
else
9595
mode='["${{ inputs.mode }}"]'
9696
fi

scripts/check_inductor_report.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def main():
7070
argparser = argparse.ArgumentParser()
7171
argparser.add_argument("--suite", required=True)
7272
argparser.add_argument("--dtype", required=True)
73-
argparser.add_argument("--mode", required=True, choices=("inference", "training", "inference-no-freezing"))
73+
argparser.add_argument("--mode", required=True, choices=("inference", "training", "inference-with-freezing"))
7474
argparser.add_argument("--test_mode", required=True, choices=("performance", "accuracy"))
7575
argparser.add_argument("--device", help="i.e. xpu", required=True)
7676
argparser.add_argument("--models-file", help="Subset of models list", required=True)

scripts/inductor_xpu_test.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,13 @@ if [[ -n "$MODEL_ONLY" ]]; then
2424
fi
2525

2626
if [[ $MODE == "inference" ]]; then
27-
Mode_extra="--inference --freezing "
27+
# For PT >= 2.1
28+
# Remove --freezing cause feature not ready
29+
Mode_extra="--inference"
2830
fi
2931

30-
if [[ $MODE == "inference-no-freezing" ]]; then
31-
Mode_extra="--inference "
32+
if [[ $MODE == "inference-with-freezing" ]]; then
33+
Mode_extra="--inference --freezing "
3234
fi
3335

3436
if [[ $MODE == "training" ]]; then

0 commit comments

Comments
 (0)