Skip to content

Commit 7d20b9e

Browse files
Remove SPV_KHR_bfloat16 workaround
Signed-off-by: Whitney Tsang <[email protected]>
1 parent daae522 commit 7d20b9e

File tree

3 files changed

+3
-26
lines changed

3 files changed

+3
-26
lines changed

third_party/intel/cmake/FindSPIRVToLLVMTranslator.cmake

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -25,30 +25,6 @@ if (NOT SPIRVToLLVMTranslator_FOUND)
2525
set(LLVM_SPIRV_BUILD_EXTERNAL YES CACHE BOOL "Build SPIRV-LLVM Translator as external" FORCE)
2626

2727
FetchContent_MakeAvailable(spirv-llvm-translator)
28-
29-
# FIXME: Don't apply patch when Agama driver is updated.
30-
execute_process(
31-
COMMAND git apply --check ${CMAKE_CURRENT_LIST_DIR}/3122.patch
32-
WORKING_DIRECTORY ${spirv-llvm-translator_SOURCE_DIR}
33-
ERROR_QUIET
34-
RESULT_VARIABLE PATCH_RESULT
35-
)
36-
if(PATCH_RESULT EQUAL 0)
37-
execute_process(
38-
COMMAND git apply ${CMAKE_CURRENT_LIST_DIR}/3122.patch
39-
WORKING_DIRECTORY ${spirv-llvm-translator_SOURCE_DIR}
40-
RESULT_VARIABLE PATCH_RESULT
41-
)
42-
else()
43-
execute_process( # Check if the patch is already applied
44-
COMMAND git apply --reverse --check ${CMAKE_CURRENT_LIST_DIR}/3122.patch
45-
WORKING_DIRECTORY ${spirv-llvm-translator_SOURCE_DIR}
46-
RESULT_VARIABLE PATCH_RESULT
47-
)
48-
endif()
49-
if(NOT PATCH_RESULT EQUAL 0)
50-
message(FATAL_ERROR "Failed to apply 3122.patch to SPIRV-LLVM-Translator")
51-
endif()
5228
endif()
5329

5430
set(SPIRVToLLVMTranslator_INCLUDE_DIR "${SPIRVToLLVMTranslator_SOURCE_DIR}/include"

third_party/intel/lib/Target/SPIRV/SPIRVTranslation.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class SmallVectorBuffer : public std::streambuf {
107107

108108
static SPIRV::TranslatorOpts getSPIRVOpts() {
109109
SPIRV::TranslatorOpts SPIRVOpts{SPIRV::VersionNumber::SPIRV_1_4};
110-
static constexpr std::array<SPIRV::ExtensionID, 18> AllowedExtensions{
110+
static constexpr std::array<SPIRV::ExtensionID, 19> AllowedExtensions{
111111
SPIRV::ExtensionID::SPV_EXT_shader_atomic_float_add,
112112
SPIRV::ExtensionID::SPV_INTEL_2d_block_io,
113113
SPIRV::ExtensionID::SPV_INTEL_arbitrary_precision_integers,
@@ -124,6 +124,7 @@ static SPIRV::TranslatorOpts getSPIRVOpts() {
124124
SPIRV::ExtensionID::SPV_INTEL_tensor_float32_conversion,
125125
SPIRV::ExtensionID::SPV_INTEL_unstructured_loop_controls,
126126
SPIRV::ExtensionID::SPV_INTEL_vector_compute,
127+
SPIRV::ExtensionID::SPV_KHR_bfloat16,
127128
SPIRV::ExtensionID::SPV_KHR_bit_instructions,
128129
SPIRV::ExtensionID::SPV_KHR_non_semantic_info};
129130

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8e8c02c4b803062501a6bd36aecdbb041fa1daef
1+
31c82e8cfc7cec7ab1cd8d3359fdd8781780c91c

0 commit comments

Comments
 (0)