Skip to content

Commit 8a774bd

Browse files
authored
Adapt benchmarks for DLE 2025.3 by removing -fpreview-breaking-changes (#5474)
Signed-off-by: Anatoly Myachev <[email protected]>
1 parent 43d761e commit 8a774bd

File tree

5 files changed

+11
-7
lines changed

5 files changed

+11
-7
lines changed

.github/actions/setup-pytorch/action.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ runs:
7878
shell: bash
7979
env:
8080
# Increase this value to reset cache
81-
CACHE_NUMBER: 18
81+
CACHE_NUMBER: 19
8282
run: |
8383
ONEAPI_LINK=$(readlink /opt/intel/oneapi || true)
8484
ONEAPI_KEY=$(sha256sum /opt/intel/installed.txt 2> /dev/null | cut -d\ -f1 || true)
@@ -124,6 +124,12 @@ runs:
124124
# FIXME: Compatibility with versions of CMake older than 3.5 has been removed, this brakes compilation of third_party/protobuf:
125125
# CMake Error at third_party/protobuf/cmake/CMakeLists.txt:2 (cmake_minimum_required)
126126
pip install 'cmake<4.0.0'
127+
# Try to avoid the following error:
128+
# A module that was compiled using NumPy 1.x cannot be run in
129+
# NumPy 2.2.6 as it may crash. To support both 1.x and 2.x
130+
# versions of NumPy, modules must be compiled with NumPy 2.0.
131+
# Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
132+
pip install 'numpy>2.0'
127133
pip install -r requirements.txt
128134
USE_XCCL=1 USE_STATIC_MKL=1 python -m build --wheel --no-isolation 2>&1 | grep -v \
129135
"Double arithmetic operation is not supported on this platform with FP64 conversion emulation mode (poison FP64 kernels is enabled)." | grep -v '^$'

benchmarks/cutlass_kernel/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ add_custom_target(generate_gemm_config DEPENDS ${GEMM_CONFIG_OUTPUT})
5858

5959
Python3_add_library(cutlass_kernel MODULE WITH_SOABI python_main.cpp)
6060

61-
target_compile_options(cutlass_kernel PRIVATE "-fsycl" "-fsycl-targets=intel_gpu_pvc,intel_gpu_bmg_g21" "-fpreview-breaking-changes")
61+
target_compile_options(cutlass_kernel PRIVATE "-fsycl" "-fsycl-targets=intel_gpu_pvc,intel_gpu_bmg_g21")
6262
target_compile_options(cutlass_kernel PRIVATE "-DCUTLASS_ENABLE_SYCL")
6363
target_compile_options(cutlass_kernel PRIVATE "-DSYCL_INTEL_TARGET")
6464
target_compile_definitions(cutlass_kernel PRIVATE GEMM_CONFIG_HEADER=\"${GEMM_CONFIG_OUTPUT}\")

benchmarks/onednn_kernel/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ set(oneDNN_KERNEL_FLAGS ${oneDNN_KERNEL_FLAGS}
55

66
Python3_add_library(onednn_kernel MODULE WITH_SOABI python_main.cpp)
77

8-
target_compile_options(onednn_kernel PRIVATE "-fsycl" "-fpreview-breaking-changes")
8+
target_compile_options(onednn_kernel PRIVATE "-fsycl")
99
target_compile_options(onednn_kernel PRIVATE "-DDNNL_CPU_RUNTIME=SYCL")
1010
target_compile_options(onednn_kernel PRIVATE "-DDNNL_GPU_RUNTIME=SYCL")
1111

benchmarks/xetla_kernel/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ endif()
2727

2828
Python3_add_library(xetla_kernel MODULE WITH_SOABI python_main.cpp)
2929
target_compile_options(xetla_kernel PRIVATE "-fPIC")
30-
target_compile_options(xetla_kernel PRIVATE "-fsycl" "-fpreview-breaking-changes")
30+
target_compile_options(xetla_kernel PRIVATE "-fsycl")
3131
target_compile_options(xetla_kernel PUBLIC "-DXETPP_NEW_XMAIN")
3232
target_link_options(xetla_kernel PRIVATE ${XETLA_KERNEL_FLAGS})
3333
target_link_libraries(xetla_kernel PUBLIC ${TORCH_LIBRARIES} ${TORCH_PYTHON_LIBRARY})

utils/SPIRVRunner/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ ExternalProject_Add(
3535
)
3636
set(JSON_INCLUDE_DIR ${CMAKE_BINARY_DIR}/nlohmann_json/src/json/include/)
3737

38-
# Add preview-breaking-changes for ABI compatibility with SYCL library linked by PyTorch:
39-
# https://github.com/pytorch/pytorch/commit/92bebb46fa9fd60523d8aeb7b5f1a3f488c4cd93
40-
set(COMPILE_FLAGS "-fsycl -Wall -fpreview-breaking-changes")
38+
set(COMPILE_FLAGS "-fsycl -Wall")
4139
set(LINK_FLAGS "-fsycl -lze_loader")
4240

4341
set(SYCL_FUNCTIONS_INCLUDE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/../../third_party/intel/backend/include")

0 commit comments

Comments
 (0)