use const& for AxisInfo constructors

Signed-off-by: Anatoly Myachev <[email protected]>

Author: anmyachev

third_party/intel/include/Analysis/AxisInfo.h

@@ -27,12 +27,12 @@ class AxisInfo {
 public:
   AxisInfo() : AxisInfo({}, {}, {}) {}
 
-  AxisInfo(DimVectorT contiguity, DimVectorT divisibility, DimVectorT constancy)
-      : AxisInfo(std::move(contiguity), std::move(divisibility),
-                 std::move(constancy), std::nullopt) {}
+  AxisInfo(const DimVectorT &contiguity, const DimVectorT &divisibility,
+           const DimVectorT &constancy)
+      : AxisInfo(contiguity, divisibility, constancy, std::nullopt) {}
 
-  AxisInfo(DimVectorT contiguity, DimVectorT divisibility, DimVectorT constancy,
-           std::optional<int64_t> constantValue)
+  AxisInfo(const DimVectorT &contiguity, const DimVectorT &divisibility,
+           const DimVectorT &constancy, std::optional<int64_t> constantValue)
       : contiguity(contiguity), divisibility(divisibility),
         constancy(constancy), constantValue(constantValue) {
     assert(divisibility.size() == contiguity.size());

third_party/intel/lib/Analysis/AxisInfo.cpp

@@ -126,8 +126,7 @@ class BinaryOpVisitorImpl : public AxisInfoVisitorImpl<OpTy> {
         divisibility.push_back(getDivisibility(op, lhsInfo, rhsInfo, d));
       }
     }
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy), constantValue);
+    return AxisInfo(contiguity, divisibility, constancy, constantValue);
   }
 
 protected:
@@ -547,8 +546,7 @@ class SplatOpAxisInfoVisitor final
       divisibility.push_back(opInfo.getDivisibility(0));
       constancy.push_back(retTy.getShape()[d]);
     }
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy),
+    return AxisInfo(contiguity, divisibility, constancy,
                     operands[0]->getValue().getConstantValue());
   }
 };
@@ -579,8 +577,7 @@ class LoadOpAxisInfoVisitor final : public AxisInfoVisitorImpl<triton::LoadOp> {
               maskInfo.has_value() ? maskInfo->getConstancy(d) : 0));
     }
 
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy));
+    return AxisInfo(contiguity, divisibility, constancy);
   }
 };
 
@@ -614,8 +611,7 @@ class ExpandDimsOpAxisInfoVisitor final
     contiguity.insert(contiguity.begin() + op.getAxis(), 1);
     divisibility.insert(divisibility.begin() + op.getAxis(), newDivisibility);
     constancy.insert(constancy.begin() + op.getAxis(), 1);
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy),
+    return AxisInfo(contiguity, divisibility, constancy,
                     operands[0]->getValue().getConstantValue());
   }
 };
@@ -644,8 +640,7 @@ class BroadcastOpAxisInfoVisitor final
       constancy.push_back(opShape[d] == 1 ? retShape[d]
                                           : opInfo.getConstancy(d));
     }
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy),
+    return AxisInfo(contiguity, divisibility, constancy,
                     operands[0]->getValue().getConstantValue());
   }
 };
@@ -720,8 +715,7 @@ class CmpOpAxisInfoVisitor final : public AxisInfoVisitorImpl<OpTy> {
       contiguity.push_back(1);
     }
 
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy), constantValue);
+    return AxisInfo(contiguity, divisibility, constancy, constantValue);
   }
 
 private:
@@ -849,8 +843,7 @@ class SelectOpAxisInfoVisitor final : public AxisInfoVisitorImpl<OpTy> {
         constantValue = lhsInfo.getConstantValue();
     }
 
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy), constantValue);
+    return AxisInfo(contiguity, divisibility, constancy, constantValue);
   }
 };
 
@@ -1003,8 +996,7 @@ class MaxMinOpAxisInfoVisitor final : public AxisInfoVisitorImpl<OpTy> {
         contiguity.push_back(
             std::min(lhsInfo.getContiguity(d), rhsInfo.getContiguity(d)));
       }
-      return AxisInfo(std::move(contiguity), std::move(divisibility),
-                      std::move(constancy), std::nullopt);
+      return AxisInfo(contiguity, divisibility, constancy, std::nullopt);
     }
   }
 };
@@ -1054,8 +1046,7 @@ class MakeTensorPtrOpAxisInfoVisitor final
 
     AxisInfo::DimVectorT constancy{1, 1};
 
-    return AxisInfo(std::move(contiguity), std::move(divisibility),
-                    std::move(constancy));
+    return AxisInfo(contiguity, divisibility, constancy);
   }
 };
 
@@ -1139,8 +1130,8 @@ LogicalResult AxisInfoAnalysis::visitOperation(
     auto vals = cast<DenseElementsAttr>(attr).getValues<int>();
     newConstancy = AxisInfo::DimVectorT(vals.begin(), vals.end());
   }
-  curr = AxisInfo(std::move(newContiguity), std::move(newDivisibility),
-                  std::move(newConstancy), curr.getConstantValue());
+  curr = AxisInfo(newContiguity, newDivisibility, newConstancy,
+                  curr.getConstantValue());
   // join all lattice elements
   for (auto *result : results)
     propagateIfChanged(result, result->join(curr));
@@ -1157,8 +1148,7 @@ void AxisInfoAnalysis::visitForOpInductionVar(
   AxisInfo::DimVectorT knownConstancy(1, 1);
   knownDivisibility[0] = gcd(lb.getDivisibility(0), step.getDivisibility(0));
   auto inductionVar =
-      AxisInfo(std::move(knownContiguity), std::move(knownDivisibility),
-               std::move(knownConstancy));
+      AxisInfo(knownContiguity, knownDivisibility, knownConstancy);
   (void)argLattices[0]->join(inductionVar);
 }
 
@@ -1245,8 +1235,7 @@ void AxisInfo::initPessimisticStateFromFunc(int argNumber, T funcOp,
     }
   }
 
-  return AxisInfo(std::move(knownContiguity), std::move(knownDivisibility),
-                  std::move(knownConstancy));
+  return AxisInfo(knownContiguity, knownDivisibility, knownConstancy);
 }
 
 /*static*/ AxisInfo AxisInfo::join(const AxisInfo &lhs, const AxisInfo &rhs) {
@@ -1268,8 +1257,7 @@ void AxisInfo::initPessimisticStateFromFunc(int argNumber, T funcOp,
       rhs.getConstantValue().has_value() &&
       lhs.getConstantValue() == rhs.getConstantValue())
     constantValue = lhs.getConstantValue();
-  return AxisInfo(std::move(contiguity), std::move(divisibility),
-                  std::move(constancy), constantValue);
+  return AxisInfo(contiguity, divisibility, constancy, constantValue);
 }
 
 unsigned ModuleAxisInfoAnalysis::getPtrContiguity(Value ptr) {