Skip to content

Commit 922ff0f

Browse files
authored
Align TritonGPU/IR/TritonGPUAttrDefs.td with upstream (#5173)
Signed-off-by: Anatoly Myachev <[email protected]>
1 parent 2f286b5 commit 922ff0f

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

include/triton/Dialect/TritonGPU/IR/TritonGPUAttrDefs.td

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ def LinearLayoutParam : AttrOrTypeParameter<"LinearLayout",
6464
// Base Attribute
6565
//===----------------------------------------------------------------------===//
6666

67-
class TritonGPU_Attr<string name, string attrMnemonic, list<Trait> traits = [], Dialect dialect = TritonGPU_Dialect>
68-
: AttrDef<dialect, name, traits> {
67+
class TritonGPU_Attr<string name, string attrMnemonic, list<Trait> traits = []>
68+
: AttrDef<TritonGPU_Dialect, name, traits> {
6969

7070
let description = [{
7171
TritonGPU tensors differ from usual tensors in that they contain a _layout_ attribute which determines
@@ -740,9 +740,8 @@ We call each individual tile "rep".
740740
];
741741
}
742742

743-
class DistributedEncoding<string name, string attrMnemonic, list<Trait> traits = [],
744-
Dialect dialect = TritonGPU_Dialect>
745-
: TritonGPU_Attr<name, attrMnemonic, !listconcat([DistributedEncodingTrait, LayoutEncodingTrait], traits), dialect> {
743+
class DistributedEncoding<string name, string attrMnemonic, list<Trait> traits = []>
744+
: TritonGPU_Attr<name, attrMnemonic, !listconcat([DistributedEncodingTrait, LayoutEncodingTrait], traits)> {
746745

747746
let description = [{
748747
Distributed encodings have a layout function L that is entirely characterized

third_party/intel/include/Dialect/TritonIntelGPU/IR/TritonIntelGPUAttrDefs.td

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ include "triton/Dialect/TritonGPU/IR/TritonGPUAttrDefs.td"
1010
//===----------------------------------------------------------------------===//
1111

1212
def DpasEncodingAttr : DistributedEncoding<"DpasEncoding", "intel_dpas_encoding",
13-
[MmaEncodingTrait, DeclareLayoutEncodingMethods], TritonIntelGPU_Dialect> {
13+
[MmaEncodingTrait, DeclareLayoutEncodingMethods]> {
14+
let dialect = TritonIntelGPU_Dialect;
1415
let mnemonic = "dpas";
1516

1617
let description = [{
@@ -254,7 +255,8 @@ The semantic of this `tt.dot` includes GEMM tiling configuration as:
254255
//===----------------------------------------------------------------------===//
255256

256257
def WarpEncodingAttr : DistributedEncoding<"WarpEncoding", "intel_warp_encoding",
257-
[DeclareLayoutEncodingMethods], TritonIntelGPU_Dialect> {
258+
[DeclareLayoutEncodingMethods]> {
259+
let dialect = TritonIntelGPU_Dialect;
258260
let mnemonic = "warp";
259261

260262
let description = [{
@@ -284,7 +286,8 @@ def WarpEncodingAttr : DistributedEncoding<"WarpEncoding", "intel_warp_encoding"
284286
// Intel Subgroup2DBlock Encoding
285287
//===----------------------------------------------------------------------===//
286288

287-
def Subgroup2DBlockEncodingAttr : DistributedEncoding<"Subgroup2DBlockEncoding", "subgroup_2d_block_encoding", [MmaEncodingTrait], TritonIntelGPU_Dialect> {
289+
def Subgroup2DBlockEncodingAttr : DistributedEncoding<"Subgroup2DBlockEncoding", "subgroup_2d_block_encoding", [MmaEncodingTrait]> {
290+
let dialect = TritonIntelGPU_Dialect;
288291
let mnemonic = "subgroup_2d_block";
289292

290293
let description = [{

0 commit comments

Comments
 (0)