Skip to content

Commit 9660a0d

Browse files
authored
[CI] Reduce MacOS CI build time (#7559)
Enabled LLD for macos build. Environmental variables defined in `ci.yml` do not get propagated to `build-macos.yml` automatically. For the reason we have to either redefine them or pass the variables explicitly. ``` [355/388, 519.606s elapsed] Linking CXX executable third_party/nvidia/unittest/Conversion/TritonGPUToLLVM/TestPtxAsmFormat [356/388, 520.757s elapsed] Linking CXX executable third_party/amd/unittest/Conversion/TestOptimizeLDS [357/388, 2380.661s elapsed] Building CXX object bin/CMakeFiles/triton-opt.dir/triton-opt.cpp.o [358/388, 2398.139s elapsed] Building CXX object bin/CMakeFiles/triton-llvm-opt.dir/triton-llvm-opt.cpp.o ``` Based on the log added by @peterbell10, the most time was spent on linking and now it's been reduced
1 parent 13b3a75 commit 9660a0d

File tree

3 files changed

+2
-10
lines changed

3 files changed

+2
-10
lines changed

.github/workflows/build-macos.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ jobs:
1616
timeout-minutes: 60
1717
env:
1818
RUNNER_TYPE: ${{ matrix.runner[0] }}
19+
TRITON_BUILD_WITH_CLANG_LLD: "TRUE"
1920
name: Build MacOS
2021
steps:
2122
- name: Checkout
@@ -95,7 +96,7 @@ jobs:
9596
env:
9697
TRITON_BUILD_WITH_O1: "true"
9798
# macos-latest has 3 vcpus and 7GB DRAM, to save memory we limit the number of jobs to 3
98-
# https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
99+
# https://docs.github.com/en/actions/reference/github-hosted-runners-reference#standard-github-hosted-runners-for-public-repositories
99100
MAX_JOBS: 3
100101
# Add elapsed time in seconds to ninja status to monitor where build stalls
101102
NINJA_STATUS: "[%f/%t, %es elapsed] "

.github/workflows/ci.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,6 @@ concurrency:
1212
group: ${{ github.ref }}
1313
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
1414
permissions: read-all
15-
env:
16-
TRITON_BUILD_WITH_CCACHE: "true"
17-
TRITON_BUILD_WITH_CLANG_LLD: "TRUE"
18-
TRITON_USE_ASSERT_ENABLED_LLVM: "TRUE"
19-
TRITON_DISABLE_LINE_INFO: 1
20-
PROTON_SKIP_PC_SAMPLING_TEST: 1
21-
PYTHON: "python3"
22-
CCACHE_COMPRESS: "true"
2315

2416
jobs:
2517

.github/workflows/integration-tests-nvidia.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ jobs:
4747
echo "llvm=$(cat $llvm_file | cut -c 1-8)" >> $GITHUB_OUTPUT
4848
echo "nvidia=$(sha256sum $nvidia_file | cut -d ' ' -f 1)" >> $GITHUB_OUTPUT
4949
echo "json=$(cat $json_file)" >> $GITHUB_OUTPUT
50-
echo "datetime=$(date -u -Iseconds)" >> $GITHUB_OUTPUT
5150
shell: bash
5251
- name: Cache build dependencies
5352
uses: actions/cache@v4

0 commit comments

Comments
 (0)