Commit 979301f
authored
Use stride instead of order to determine block attr (#2349)
Per the Triton slack, `order` is unused on architecture below Hopper.
But more importantly, order provides information that stride already
has. In fact, order can be completely different from stride (i.e. wrong)
and we still generate correct code. I think it is better to use the
stride assuming the logic I added here makes sense.
Note this depends on #2348, I'd like to land the debug logging
separately, so we have it even if we decide to modify this approach. It
was very useful in debugging this problem.
cc #23471 parent 19527ac commit 979301f
File tree
1 file changed
+17
-6
lines changed- third_party/intel/lib/TritonIntelGPUTransforms
1 file changed
+17
-6
lines changedLines changed: 17 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
| 54 | + | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
61 | 69 | | |
62 | | - | |
63 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
64 | 73 | | |
| 74 | + | |
65 | 75 | | |
66 | 76 | | |
67 | 77 | | |
| |||
77 | 87 | | |
78 | 88 | | |
79 | 89 | | |
80 | | - | |
| 90 | + | |
| 91 | + | |
81 | 92 | | |
82 | 93 | | |
83 | 94 | | |
| |||
0 commit comments