Skip to content

Commit 9b1def1

Browse files
committed
Fixed sglang testing, added pin, updated fix
1 parent f674b76 commit 9b1def1

File tree

5 files changed

+321
-147
lines changed

5 files changed

+321
-147
lines changed

.github/workflows/sglang-tests.yml

Lines changed: 0 additions & 100 deletions
This file was deleted.

.github/workflows/third-party-tests.yml

Lines changed: 68 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Third party tests [liger-kernels, vllm]
1+
name: Third party tests [liger-kernels, vllm, sglang]
22

33
on:
44
workflow_dispatch:
@@ -28,12 +28,12 @@ env:
2828
TAG: ${{ inputs.tag || (github.event_name == 'pull_request' && format('pr-{0}', github.event.number)) || (github.event_name == 'schedule' && 'ci') || 'test' }}
2929

3030
jobs:
31-
build:
32-
name: Third party tests [liger-kernels, vllm]
31+
small-tests:
32+
name: Third party tests [vllm, sglang]
3333
runs-on:
3434
- linux
3535
- ${{ inputs.runner_label || 'max1550' }}
36-
timeout-minutes: 720
36+
timeout-minutes: 120
3737
defaults:
3838
run:
3939
shell: bash -noprofile --norc -eo pipefail -c "source /opt/intel/oneapi/setvars.sh > /dev/null; source {0}"
@@ -47,14 +47,7 @@ jobs:
4747
- name: Checkout repository
4848
uses: actions/checkout@v5
4949

50-
- name: Install Python
51-
if: ${{ !(inputs.use_pyenv_python || false) }}
52-
uses: actions/setup-python@v6
53-
with:
54-
python-version: ${{ env.PYTHON_VERSION }}
55-
5650
- name: Install Python (from pyenv) ${{ inputs.python_version }}
57-
if: ${{ inputs.use_pyenv_python }}
5851
uses: ./.github/actions/setup-pyenv-python
5952
with:
6053
python-version: ${{ env.PYTHON_VERSION }}
@@ -86,19 +79,81 @@ jobs:
8679
mkdir reports
8780
echo "REPORTS=$PWD/reports" >> $GITHUB_ENV
8881
82+
- name: Run SGLANG tests
83+
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
84+
run: |
85+
./scripts/test-triton.sh --sglang --skip-pip-install --skip-pytorch-install
86+
8987
- name: Run VLLM tests
9088
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
9189
run: |
9290
./scripts/test-triton.sh --vllm --skip-pip-install --skip-pytorch-install
9391
94-
- name: Run Liger-Kernel tests
92+
- name: Upload test report
9593
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
94+
uses: actions/upload-artifact@v4
95+
with:
96+
name: test-main-reports
97+
path: reports
98+
# We run all tests for Liger, so it's slow and we test it separately
99+
liger:
100+
name: Liger testing
101+
runs-on:
102+
- linux
103+
- ${{ inputs.runner_label || 'max1550' }}
104+
timeout-minutes: 120
105+
defaults:
106+
run:
107+
shell: bash -noprofile --norc -eo pipefail -c "source /opt/intel/oneapi/setvars.sh > /dev/null; source {0}"
108+
steps:
109+
- name: Print inputs
110+
run: |
111+
cat <<EOF
112+
${{ toJSON(inputs) }}
113+
EOF
114+
115+
- name: Checkout repository
116+
uses: actions/checkout@v5
117+
118+
- name: Install Python (from pyenv) ${{ inputs.python_version }}
119+
uses: ./.github/actions/setup-pyenv-python
120+
with:
121+
python-version: ${{ env.PYTHON_VERSION }}
122+
123+
- name: Identify Python version
124+
run: |
125+
PYTHON_VERSION="$(python -c 'import sys; print(f"{sys.version_info[0]}.{ sys.version_info[1]}")')"
126+
echo "PYTHON_VERSION=$PYTHON_VERSION" | tee -a $GITHUB_ENV
127+
128+
- name: Install Python build dependencies
129+
run: |
130+
pip install cmake
131+
132+
- name: Setup PyTorch
133+
uses: ./.github/actions/setup-pytorch
134+
135+
- name: Build Triton wheels
136+
uses: ./.github/actions/setup-triton
137+
with:
138+
command: DEBUG=1 python -m build --wheel --no-isolation
139+
140+
- name: Install Triton
141+
id: install
142+
run: |
143+
pip install dist/*.whl
144+
145+
- name: Create reports dir
146+
run: |
147+
mkdir reports
148+
echo "REPORTS=$PWD/reports" >> $GITHUB_ENV
149+
150+
- name: Run Liger-Kernel tests
96151
run: |
97152
./scripts/test-triton.sh --liger --skip-pip-install --skip-pytorch-install
98153
99154
- name: Upload test report
100155
if: ${{ steps.install.outcome == 'success' && !cancelled() }}
101156
uses: actions/upload-artifact@v4
102157
with:
103-
name: test-reports
158+
name: test-liger-reports
104159
path: reports

0 commit comments

Comments
 (0)