Skip to content

Commit 9d9ad31

Browse files
authored
Fix the total number of tests for LTS (#3994)
Previously for LTS we didn't run the instrumentation test, because pytest does not work when all tests are deselected. Now, with the new pytest-skip plugin, the test is skipped, and it is safe to remove the old code for LTS. This should fix the long living issue with the total number of tests for LTS is less than for rolling.
1 parent 3bcc576 commit 9d9ad31

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

scripts/test-triton.sh

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -348,13 +348,6 @@ run_benchmarks() {
348348
}
349349

350350
run_instrumentation_tests() {
351-
# FIXME: the "instrumentation" test suite currently contains only one test, when all tests
352-
# are skipped pytest reports an error. If the only test is the skip list, then we shouldn't
353-
# run pytest at all. This must be changed when there is more than one instrumentation test.
354-
if [[ $TEST_UNSKIP = false && -s $TRITON_TEST_SKIPLIST_DIR/instrumentation.txt ]]; then
355-
return
356-
fi
357-
358351
INSTRUMENTATION_LIB_DIR=$(ls -1d $TRITON_PROJ/python/build/*lib*/triton/instrumentation) || err "Could not find $TRITON_PROJ/python/build/*lib*/triton/instrumentation, build Triton first"
359352
INSTRUMENTATION_LIB_NAME=$(ls -1 $INSTRUMENTATION_LIB_DIR/*GPUInstrumentationTestLib* | head -n1)
360353

0 commit comments

Comments
 (0)