Commit 9fbf44f
[AMD] Add messages for debugging BlockPingpong (#8804)
For some num_warps, num_stages and tile_size, BlockPingpong will exit
early without leaving a message.
Added message for these cases so people can be aware that pingpong
wasn't really involved. Also add some transparency for debugging. This
shouldn't change the way how BlockPingong or anything else in Triton is
used.
<!---
The core Triton is a small number of people, and we receive many PRs
(thank
you!). To help us review your code more quickly, **if you are a new
contributor (less than 3 PRs merged) we ask that you complete the
following
tasks and include the filled-out checklist in your PR description.**
Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them.
-->
# New contributor declaration
- [X] I am not making a trivial change, such as fixing a typo in a
comment.
- [X] I have written a PR description following these
[rules](https://cbea.ms/git-commit/#why-not-how).
- [X] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`.
- Select one of the following.
- [ ] I have added tests.
- `/test` for `lit` tests
- `/unittest` for C++ tests
- `/python/test` for end-to-end tests
- [X] This PR does not need a test because `Just added a few message to
make sure BlockPingpong won't silently exit early, making it easier to
debug`.
- Select one of the following.
- [X] I have not added any `lit` tests.
- [ ] The `lit` tests I have added follow these [best
practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices),
including the "tests should be minimal" section. (Usually running Python
code
and using the instructions it generates is not minimal.)
Co-authored-by: Peiying Hua <[email protected]>1 parent 2760a7e commit 9fbf44f
File tree
1 file changed
+20
-2
lines changed- third_party/amd/lib/TritonAMDGPUTransforms
1 file changed
+20
-2
lines changedLines changed: 20 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1185 | 1185 | | |
1186 | 1186 | | |
1187 | 1187 | | |
1188 | | - | |
| 1188 | + | |
1189 | 1189 | | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
1190 | 1201 | | |
1191 | 1202 | | |
1192 | 1203 | | |
| |||
1216 | 1227 | | |
1217 | 1228 | | |
1218 | 1229 | | |
1219 | | - | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
| 1233 | + | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
1220 | 1237 | | |
| 1238 | + | |
1221 | 1239 | | |
1222 | 1240 | | |
1223 | 1241 | | |
| |||
0 commit comments