Skip to content

Commit a30754e

Browse files
[FA] Remove IGC_DisableLoopUnroll=1 (#2416)
No performance impact. Signed-off-by: Whitney Tsang <[email protected]>
1 parent d651a84 commit a30754e

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

.github/workflows/triton-benchmarks.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,6 @@ jobs:
222222
TRITON_INTEL_ADVANCED_PATH=0 \
223223
TRITON_INTEL_ENABLE_ADDRESS_PAYLOAD_OPT=1 \
224224
IGC_VISAOptions=" -enableBCR -nolocalra -printregusage -DPASTokenReduction -enableHalfLSC -abiver 2" \
225-
IGC_DisableLoopUnroll=1 \
226225
python flash_attention_fwd_benchmark.py --reports $REPORTS
227226
228227
TAG=${{ inputs.tag || 'ci' }}-dflt
@@ -237,7 +236,6 @@ jobs:
237236
TRITON_INTEL_ENABLE_INSTR_SCHED=1 \
238237
TRITON_INTEL_ENABLE_ADDRESS_PAYLOAD_OPT=1 \
239238
IGC_VISAOptions=" -enableBCR -nolocalra -printregusage -DPASTokenReduction -enableHalfLSC -abiver 2" \
240-
IGC_DisableLoopUnroll=1 \
241239
python flash_attention_fwd_benchmark.py --reports $REPORTS
242240
243241
TAG=${{ inputs.tag || 'ci' }}-adv

scripts/test-triton.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,15 +280,13 @@ run_benchmark_attention() {
280280
TRITON_INTEL_ADVANCED_PATH=0 \
281281
TRITON_INTEL_ENABLE_ADDRESS_PAYLOAD_OPT=1 \
282282
IGC_VISAOptions=" -enableBCR -nolocalra -printregusage -DPASTokenReduction -enableHalfLSC" \
283-
IGC_DisableLoopUnroll=1 \
284283
python $TRITON_PROJ/benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchmark.py
285284

286285
echo "Advanced path:"
287286
TRITON_INTEL_ADVANCED_PATH=1 \
288287
TRITON_INTEL_ENABLE_ADDRESS_PAYLOAD_OPT=1 \
289288
TRITON_INTEL_ENABLE_INSTR_SCHED=1 \
290289
IGC_VISAOptions=" -enableBCR -nolocalra -printregusage -DPASTokenReduction -enableHalfLSC" \
291-
IGC_DisableLoopUnroll=1 \
292290
python $TRITON_PROJ/benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchmark.py
293291
}
294292

0 commit comments

Comments
 (0)