Skip to content

Commit a5140b7

Browse files
authored
Less verbose auto-update-translator-cid (#2551)
Fixes #2302.
1 parent c6f9788 commit a5140b7

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

.github/workflows/auto-update-translator-cid.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ jobs:
8686
- name: Search the latest valid Translator cid
8787
if: ${{ env.TARGET_PRID == null }}
8888
run: |
89-
env
9089
./scripts/check-update-translator-cid.sh $CID_LATEST $CID_CURRENT
9190
if git status --porcelain ./lib/Target/SPIRV/spirv-llvm-translator.conf | grep '^ M'; then
9291
echo "MODIFIED=true" >> $GITHUB_ENV

scripts/check-update-translator-cid.sh

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,22 @@ cd $TRITON_PROJ
2626
FOUND=false
2727
for cid in $COMMIT_IDS; do
2828
echo "$cid" > ./lib/Target/SPIRV/spirv-llvm-translator.conf
29-
if ! ./scripts/compile-triton.sh --clean; then
30-
echo "Triton compile failed for translator commit $cid"
29+
30+
BUILD_STATUS=PASS
31+
echo "::group::Building Triton for $cid"
32+
./scripts/compile-triton.sh --clean || BUILD_STATUS=FAIL
33+
echo "::endgroup::"
34+
35+
if [ $BUILD_STATUS != PASS ]; then
3136
continue
3237
fi
3338

34-
# execute default tests
35-
if ./scripts/test-triton.sh --skip-pytorch-install; then
39+
TEST_STATUS=PASS
40+
echo "::group::Testing Triton for $cid"
41+
./scripts/test-triton.sh --skip-pytorch-install || TEST_STATUS=FAIL
42+
echo "::endgroup::"
43+
44+
if [ $TEST_STATUS = PASS ]; then
3645
echo "Tests passed for translator commit $cid"
3746
echo "A newer commit found: $cid"
3847
FOUND=true

scripts/compile-triton.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ build_triton() {
179179

180180
cd python
181181
# Install triton and its dependencies.
182-
pip install -vvv -e '.[build,tests]'
182+
pip install -v -e '.[build,tests]'
183183

184184
# Copy compile_commands.json in the build directory (so that cland vscode plugin can find it).
185185
cp $(find $TRITON_PROJ_BUILD -name compile_commands.json) $TRITON_PROJ/

0 commit comments

Comments
 (0)