Skip to content

Commit ace916b

Browse files
authored
E2E on Windows (stub) (#4446)
A new GitHub workflow "E2E on Windows". The workflow currently does nothing. This PR needs to be merged in main to enable running the workflow manually. All work will be done in the following PRs. --------- Signed-off-by: Pavel Chekin <[email protected]>
1 parent f0dbc5d commit ace916b

File tree

7 files changed

+281
-44
lines changed

7 files changed

+281
-44
lines changed

.github/workflows/build-test-windows.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ jobs:
3434
# Building PyTorch can take up to 4 hours on certain machines, increasing the timeout to 8 hours.
3535
timeout-minutes: 720
3636
steps:
37-
- name: Enable long paths
38-
run: |
39-
git config --system core.longPaths true
40-
4137
- name: Checkout repository
4238
uses: actions/checkout@v4
4339

.github/workflows/build-windows.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ jobs:
2323
runs-on:
2424
- windows
2525
steps:
26-
- name: Enable long paths
27-
run: |
28-
git config --system core.longPaths true
29-
3026
- name: Checkout repository
3127
uses: actions/checkout@v4
3228

.github/workflows/e2e-accuracy.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ on:
3838
- float32
3939
default: all
4040
models:
41-
description: Run all models or a subset from .github/models/performance/{suite}.txt
41+
description: Run all models or a subset from .github/models/accuracy/{suite}.txt
4242
type: choice
4343
options:
4444
- all
4545
- subset
4646
default: all
4747
check_all_subset_models:
48-
description: In "subset" mode, check all subset models
48+
description: In "subset" mode, keep going after errors
4949
type: boolean
5050
default: false
5151
only_one_model:
@@ -70,7 +70,7 @@ permissions: read-all
7070
jobs:
7171
setup:
7272
name: Setup
73-
runs-on: Linux
73+
runs-on: linux
7474
outputs:
7575
suite: ${{ steps.set-matrix.outputs.suite }}
7676
mode: ${{ steps.set-matrix.outputs.mode }}
@@ -99,11 +99,6 @@ jobs:
9999
echo "mode=$mode" >> $GITHUB_OUTPUT
100100
echo "dtype=$dtype" >> $GITHUB_OUTPUT
101101
102-
print_inputs:
103-
name: Print inputs
104-
needs: setup
105-
runs-on: Linux
106-
steps:
107102
- name: Print inputs
108103
run: |
109104
cat <<EOF
@@ -113,7 +108,7 @@ jobs:
113108
- name: Print setup outputs
114109
run: |
115110
cat <<EOF
116-
${{ toJSON(needs.setup.outputs) }}
111+
${{ toJSON(steps.set-matrix.outputs) }}
117112
EOF
118113
119114
run_tests:

.github/workflows/e2e-performance.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@ on:
3838
- float32
3939
default: all
4040
models:
41-
description: Run all models or a subset
41+
description: Run all models or a subset from .github/models/performance/{suite}.txt
4242
type: choice
4343
options:
4444
- all
4545
- subset
4646
default: subset
4747
check_all_subset_models:
48-
description: In "subset" mode, do not fail workflow if one of models failed
48+
description: In "subset" mode, keep going after errors
4949
type: boolean
5050
default: false
5151
only_one_model:
@@ -70,7 +70,7 @@ permissions: read-all
7070
jobs:
7171
setup:
7272
name: Setup
73-
runs-on: Linux
73+
runs-on: linux
7474
outputs:
7575
suite: ${{ steps.set-matrix.outputs.suite }}
7676
mode: ${{ steps.set-matrix.outputs.mode }}
@@ -106,11 +106,6 @@ jobs:
106106
echo "dtype=$dtype" >> $GITHUB_OUTPUT
107107
echo "models=$models" >> $GITHUB_OUTPUT
108108
109-
print_inputs:
110-
name: Print inputs
111-
needs: setup
112-
runs-on: Linux
113-
steps:
114109
- name: Print inputs
115110
run: |
116111
cat <<EOF
@@ -120,7 +115,7 @@ jobs:
120115
- name: Print setup outputs
121116
run: |
122117
cat <<EOF
123-
${{ toJSON(needs.setup.outputs) }}
118+
${{ toJSON(steps.set-matrix.outputs) }}
124119
EOF
125120
126121
run_tests:

.github/workflows/e2e-reusable.yml

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ permissions: read-all
4949
env:
5050
TRITON_DISABLE_LINE_INFO: 1
5151
PYTHON_VERSION: "3.10"
52+
BENCHMARK_REPO: pytorch/benchmark
5253

5354
jobs:
5455
run_tests:
@@ -99,23 +100,15 @@ jobs:
99100
with:
100101
ref: ${{ inputs.pytorch_ref }}
101102

102-
- name: Set benchmark repository
103-
run: |
104-
echo "BENCHMARK_REPO=pytorch/benchmark" | tee -a "$GITHUB_ENV"
105-
106-
- name: Get benchmark commit id
107-
run: |
108-
cd pytorch
109-
echo "BENCHMARK_COMMIT_ID=$(<.github/ci_commit_pins/torchbench.txt)" | tee -a "$GITHUB_ENV"
110-
111103
- name: Identify pinned versions
112104
run: |
113105
cd pytorch
114-
echo "TORCHVISION_COMMIT_ID=$(<.github/ci_commit_pins/vision.txt)" >> "${GITHUB_ENV}"
115-
echo "TORCHTEXT_COMMIT_ID=$(<.github/ci_commit_pins/text.txt)" >> "${GITHUB_ENV}"
116-
echo "TORCHAUDIO_COMMIT_ID=$(<.github/ci_commit_pins/audio.txt)" >> "${GITHUB_ENV}"
117-
echo "TRANSFORMERS_VERSION=$(<.ci/docker/ci_commit_pins/huggingface.txt)" >> "${GITHUB_ENV}"
118-
echo "TIMM_COMMIT_ID=$(<.ci/docker/ci_commit_pins/timm.txt)" >> "${GITHUB_ENV}"
106+
echo "BENCHMARK_COMMIT_ID=$(<.github/ci_commit_pins/torchbench.txt)" | tee -a "$GITHUB_ENV"
107+
echo "TORCHVISION_COMMIT_ID=$(<.github/ci_commit_pins/vision.txt)" | tee -a "$GITHUB_ENV"
108+
echo "TORCHTEXT_COMMIT_ID=$(<.github/ci_commit_pins/text.txt)" | tee -a "$GITHUB_ENV"
109+
echo "TORCHAUDIO_COMMIT_ID=$(<.github/ci_commit_pins/audio.txt)" | tee -a "$GITHUB_ENV"
110+
echo "TRANSFORMERS_VERSION=$(<.ci/docker/ci_commit_pins/huggingface.txt)" | tee -a "$GITHUB_ENV"
111+
echo "TIMM_COMMIT_ID=$(<.ci/docker/ci_commit_pins/timm.txt)" | tee -a "$GITHUB_ENV"
119112
120113
- name: Generate Triton cache key
121114
id: triton-key

0 commit comments

Comments
 (0)