[Frontend] Always verify with diagnostics (#8074)

This ensures diagnostics are emitted with source information.

Author: Mogball

python/src/ir.cc

@@ -554,6 +554,8 @@ void init_triton_ir(py::module &&m) {
            })
       .def("verify",
            [](OpState &self) -> bool {
+             TritonSourceMgrDiagnosticHandler handler =
+                 setupTritonDiagnosticHandler(self.getContext());
              return succeeded(verify(self.getOperation()));
            })
       .def("get_operation", [](OpState &self) { return self.getOperation(); });
@@ -700,12 +702,7 @@ void init_triton_ir(py::module &&m) {
       .def("walk",
            [](ModuleOp &self, const std::function<void(Operation *)> &fn) {
              self.walk(fn);
-           })
-      .def("verify_with_diagnostics", [](ModuleOp &self) {
-        TritonSourceMgrDiagnosticHandler handler =
-            setupTritonDiagnosticHandler(self.getContext());
-        return succeeded(verify(self.getOperation()));
-      });
+           });
 
   m.def("make_attr", [](const std::vector<int> &values, MLIRContext &context) {
     return mlir::cast<Attribute>(DenseIntElementsAttr::get(

python/triton/_filecheck.py

@@ -74,7 +74,6 @@ def run_parser(kernel_fn, args=(), kwargs={}, target=stub_target):
     codegen_fns = backend.get_codegen_implementation(options)
     module_map = backend.get_module_map()
     module = src.make_ir(target, options, codegen_fns, module_map, context)
-    assert module.verify()
     return module
 
 

python/triton/compiler/code_generator.py

@@ -1595,7 +1595,7 @@ def ast_to_ttir(fn, src, context, options, codegen_fns, module_map, module=None)
     module = generator.module
     # module takes ownership of the context
     module.context = context
-    if not module.verify_with_diagnostics():
+    if not module.verify():
         if not fn.is_gluon():
             print(module)
         raise RuntimeError("error encountered during parsing")

python/triton/language/semantic.py

@@ -1755,7 +1755,7 @@ def map_elementwise(self, inputs: Sequence[tl.tensor], result_types: Sequence[tl
             pack,
         )
         region_builder_fn(elementwise_op)
-        # assert elementwise_op.verify()
+        assert elementwise_op.verify()
 
         return tuple(self.tensor(elementwise_op.get_result(i), ty) for i, ty in enumerate(result_types))