Skip to content

Commit e7d0e43

Browse files
committed
Revert "[BACKEND] bump to llvm/llvm-project@e12cbd8 (#6880)"
This reverts commit 75fe113.
1 parent 19c32a7 commit e7d0e43

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

cmake/llvm-hash.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
e12cbd8339b89563059c2bb2a312579b652560d0
1+
3c709802d31b5bc5ed3af8284b40593ff39b9eec

test/Conversion/amd/async_ops_to_llvm.mlir

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,13 +259,16 @@ module attributes {"ttg.num-ctas" = 1 : i32, "ttg.num-warps" = 16 : i32, ttg.sha
259259
// Each thread needs to load 1 element and we load 1 (sizePerThread) per global.load.lds
260260

261261
// CHECK: llvm.getelementptr
262-
// CHECK: rocdl.global.load.lds {{.*}}, {{.*}}, 4, 0, 0
262+
// CHECK: %[[aux_ca:.*]] = llvm.mlir.constant(0 : i32) : i32
263+
// CHECK: rocdl.global.load.lds {{.*}}, {{.*}}, {{.*}}, {{.*}}, %[[aux_ca]]
263264
%2 = ttg.async_copy_global_to_local %1, %arg2 cacheModifier = ca: tensor<32x32x!tt.ptr<f32>, #blocked> -> <32x32xf32, #shared, #smem, mutable>
264265
// CHECK: llvm.getelementptr
265-
// CHECK: rocdl.global.load.lds {{.*}}, {{.*}}, 4, 0, 3
266+
// CHECK: %[[aux_cg:.*]] = llvm.mlir.constant(3 : i32) : i32
267+
// CHECK: rocdl.global.load.lds {{.*}}, {{.*}}, {{.*}}, {{.*}}, %[[aux_cg]]
266268
%3 = ttg.async_copy_global_to_local %1, %arg2 cacheModifier = cg: tensor<32x32x!tt.ptr<f32>, #blocked> -> <32x32xf32, #shared, #smem, mutable>
267269
// CHECK: llvm.getelementptr
268-
// CHECK: rocdl.global.load.lds {{.*}}, {{.*}}, 4, 0, 17
270+
// CHECK: %[[aux_cv:.*]] = llvm.mlir.constant(17 : i32) : i32
271+
// CHECK: rocdl.global.load.lds {{.*}}, {{.*}}, {{.*}}, {{.*}}, %[[aux_cv]]
269272
%4 = ttg.async_copy_global_to_local %1, %arg2 cacheModifier = cv: tensor<32x32x!tt.ptr<f32>, #blocked> -> <32x32xf32, #shared, #smem, mutable>
270273
tt.return
271274
}

third_party/amd/lib/TritonAMDGPUToLLVM/LoadStoreOpToLLVM.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -639,9 +639,10 @@ struct AsyncCopyGlobalToLocalOpConversion
639639
(vecTy.getNumElements() * vecTy.getElementTypeBitWidth()) / 8;
640640
assert(llvm::isPowerOf2_32(vecBytes));
641641
Value vecBytesVal = b.i32_val(vecBytes);
642-
int32_t cacheModifiers =
643-
mlir::LLVM::AMD::getCtrlBitsForCacheModifierOnTarget(
644-
op.getCache(), /*isLoad=*/true, targetInfo);
642+
643+
Value cacheModifiers =
644+
b.i32_val(mlir::LLVM::AMD::getCtrlBitsForCacheModifierOnTarget(
645+
op.getCache(), /*isLoad=*/true, targetInfo));
645646

646647
Value llMask = adaptor.getMask();
647648
SmallVector<Value> maskElems;
@@ -679,7 +680,7 @@ struct AsyncCopyGlobalToLocalOpConversion
679680
auto globalLoadLdsOp = rewriter.create<ROCDL::GlobalLoadLDSOp>(
680681
loc,
681682
/*globalPtr=*/srcPtr, /*ldsPtr=*/coalescedShmemAddr[i],
682-
/*size=*/vecBytes, /*offset=*/0,
683+
/*size=*/vecBytesVal, /*offset=*/b.i32_val(0),
683684
/*aux=*/cacheModifiers, /*alias_scopes=*/nullptr,
684685
/*noalias_scopes=*/nullptr, /*tbaa=*/nullptr);
685686
LLVM::AMD::addAsyncCopyAliasScope(globalLoadLdsOp);
@@ -694,8 +695,8 @@ struct AsyncCopyGlobalToLocalOpConversion
694695
rewriter.create<LLVM::CondBrOp>(loc, pred, loadBlock, afterLoad);
695696
rewriter.setInsertionPointToStart(loadBlock);
696697
auto globalLoadLdsOp = rewriter.create<ROCDL::GlobalLoadLDSOp>(
697-
loc, srcPtr, coalescedShmemAddr[i], vecBytes,
698-
/*offset=*/0, cacheModifiers, nullptr, nullptr, nullptr);
698+
loc, srcPtr, coalescedShmemAddr[i], vecBytesVal,
699+
/*offset=*/b.i32_val(0), cacheModifiers, nullptr, nullptr, nullptr);
699700
LLVM::AMD::addAsyncCopyAliasScope(globalLoadLdsOp);
700701

701702
rewriter.create<LLVM::BrOp>(loc, afterLoad);

0 commit comments

Comments
 (0)