Skip to content

Commit f3ad673

Browse files
[CI][GEMM][FA] Remove default path with env vars configuration (#2882)
The performance of default path without env vars is similar to the performance of default path with env vars. This PR removes running default path with env vars in CI. Signed-off-by: Whitney Tsang <[email protected]>
1 parent ba7a1c3 commit f3ad673

File tree

2 files changed

+6
-36
lines changed

2 files changed

+6
-36
lines changed

.github/workflows/triton-benchmarks.yml

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -157,21 +157,8 @@ jobs:
157157
source ../../scripts/capture-hw-details.sh
158158
python ../../scripts/build_report.py $REPORTS/matmul-performance-base.csv $REPORTS/gemm-triton-report.csv --benchmark gemm --compiler triton --param_cols "B,M,K,N" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
159159
python ../../scripts/build_report.py $REPORTS/matmul-performance-base.csv $REPORTS/gemm-xetla-report.csv --benchmark gemm --compiler xetla --param_cols "B,M,K,N" --tflops_col XeTLA-TFlops --hbm_col "XeTLA-GB/s" --tag $TAG
160-
161-
- name: Run Triton GEMM kernel benchmark - default path
162-
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'gemm_benchmark.py_default') }}
163-
run: |
164-
cd benchmarks/triton_kernels_benchmark
165-
# Default path:
166-
TRITON_INTEL_ADVANCED_PATH=0 \
167-
IGC_VISAOptions=" -enableBCR -nolocalra" \
168-
IGC_DisableLoopUnroll=1 \
169-
python gemm_benchmark.py --reports $REPORTS
170-
mv $REPORTS/matmul-performance.csv $REPORTS/matmul-performance-default-path.csv
171-
172-
source ../../scripts/capture-hw-details.sh
173-
TAG="${TAG}-dflt"
174-
python ../../scripts/build_report.py $REPORTS/matmul-performance-default-path.csv $REPORTS/gemm-triton-default-report.csv --benchmark gemm --compiler triton --param_cols "B,M,K,N" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
160+
# FIXME: Remove after Grafana migration
161+
python ../../scripts/build_report.py $REPORTS/matmul-performance-base.csv $REPORTS/gemm-triton-report.csv --benchmark gemm --compiler triton --param_cols "B,M,K,N" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag ${TAG}-dflt
175162
176163
- name: Run Triton GEMM kernel benchmark - advanced path
177164
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'gemm_benchmark.py_advanced') }}
@@ -259,19 +246,8 @@ jobs:
259246
source ../../scripts/capture-hw-details.sh
260247
python ../../scripts/build_report.py $REPORTS/attn-performance.csv $REPORTS/attn-triton-report.csv --benchmark attn --compiler triton --param_cols "Z,H,N_CTX,D_HEAD,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
261248
python ../../scripts/build_report.py $REPORTS/attn-performance.csv $REPORTS/attn-xetla-report.csv --benchmark attn --compiler xetla --param_cols "Z,H,N_CTX,D_HEAD,CAUSAL" --tflops_col XeTLA-TFlops --hbm_col "XeTLA-GB/s" --tag $TAG
262-
263-
- name: Run Triton FA kernel benchmark - default path
264-
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmark || '[]'), 'flash_attention_fwd_benchmark.py_default') }}
265-
run: |
266-
cd benchmarks/triton_kernels_benchmark
267-
TRITON_INTEL_ADVANCED_PATH=0 \
268-
TRITON_INTEL_ENABLE_ADDRESS_PAYLOAD_OPT=1 \
269-
IGC_VISAOptions=" -enableBCR" \
270-
python flash_attention_fwd_benchmark.py --reports $REPORTS
271-
272-
TAG="${TAG}-dflt"
273-
source ../../scripts/capture-hw-details.sh
274-
python ../../scripts/build_report.py $REPORTS/attn-performance.csv $REPORTS/attn-triton-default-report.csv --benchmark attn --compiler triton --param_cols "Z,H,N_CTX,D_HEAD,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG
249+
# FIXME: Remove after Grafana migration
250+
python ../../scripts/build_report.py $REPORTS/attn-performance.csv $REPORTS/attn-triton-default-report.csv --benchmark attn --compiler triton --param_cols "Z,H,N_CTX,D_HEAD,CAUSAL" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag ${TAG}-dflt
275251
276252
- name: Run Triton FA kernel benchmark - advanced path
277253
if: ${{ steps.install.outcome == 'success' && !cancelled() && !contains(fromJson(inputs.skip_benchmarks || '[]'), 'flash_attention_fwd_benchmark.py_advanced') }}

scripts/test-triton.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -263,10 +263,7 @@ run_benchmark_gemm() {
263263
python setup.py install
264264

265265
echo "Default path:"
266-
TRITON_INTEL_ADVANCED_PATH=0 \
267-
IGC_VISAOptions=" -enableBCR -nolocalra" \
268-
IGC_DisableLoopUnroll=1 \
269-
python $TRITON_PROJ/benchmarks/triton_kernels_benchmark/gemm_benchmark.py
266+
python $TRITON_PROJ/benchmarks/triton_kernels_benchmark/gemm_benchmark.py
270267

271268
echo "Advanced path:"
272269
TRITON_INTEL_ADVANCED_PATH=1 \
@@ -283,10 +280,7 @@ run_benchmark_attention() {
283280
python setup.py install
284281

285282
echo "Default path:"
286-
TRITON_INTEL_ADVANCED_PATH=0 \
287-
TRITON_INTEL_ENABLE_ADDRESS_PAYLOAD_OPT=1 \
288-
IGC_VISAOptions=" -enableBCR" \
289-
python $TRITON_PROJ/benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchmark.py
283+
python $TRITON_PROJ/benchmarks/triton_kernels_benchmark/flash_attention_fwd_benchmark.py
290284

291285
echo "Advanced path:"
292286
TRITON_INTEL_ADVANCED_PATH=1 \

0 commit comments

Comments
 (0)