Address code review comments

Signed-off-by: Ettore Tiotto <[email protected]>

Author: etiotto

third_party/intel/lib/Dialect/Triton/Transforms/RemoveMasks.cpp

@@ -34,24 +34,21 @@ static Operation *dropMask(Operation *op, bool maskVal) {
   TypeSwitch<Operation *>(op)
       .Case<tt::LoadOp>([&](auto loadOp) {
         if (maskVal) {
-          tt::LoadOp newLoadOp = builder.create<tt::LoadOp>(
-              loc, loadOp.getPtr(), loadOp.getCache(), loadOp.getEvict(),
+          auto newLoadOp = builder.create<tt::LoadOp>(
+              loc, loadOp.getPtr(), loadOp.getBoundaryCheck(),
+              loadOp.getPadding(), loadOp.getCache(), loadOp.getEvict(),
               loadOp.getIsVolatile());
           loadOp->replaceAllUsesWith(newLoadOp);
         } else {
-          Value other = loadOp.getOther();
-          Operation *cstOp = builder.create<arith::ConstantOp>(loc, other);
+          Operation *cstOp =
+              builder.create<arith::ConstantOp>(loc, loadOp.getOther());
           loadOp->replaceAllUsesWith(cstOp);
         }
       })
       .Case<arith::SelectOp>([&](auto selectOp) {
         selectOp->replaceAllUsesWith(
             (maskVal ? selectOp.getTrueValue() : selectOp.getFalseValue())
                 .getDefiningOp());
-      })
-      .Default([](auto) {
-        return nullptr;
-        llvm_unreachable("Unexpected operation");
       });
 
   return nullptr;
@@ -673,7 +670,7 @@ struct TritonIntelRemoveMasksBase
   void runOnOperation() final {
     ModuleOp moduleOp = getOperation();
 
-    // Remove masks if the are not necessary
+    // Remove masks if they are not necessary.
     moduleOp->walk<WalkOrder::PreOrder>([&](Operation *op) {
       if (scf::ForOp forOp = dyn_cast<scf::ForOp>(op)) {
         // Nested loop aren't currently handled.