Skip to content

Commit fff1b0c

Browse files
[Intel] Remove ViewOpToLLVM (#3579)
There is no need to specialize `ViewOpToLLVM` conversion anymore, we can reuse the common version. Signed-off-by: Whitney Tsang <[email protected]>
1 parent a8332a5 commit fff1b0c

File tree

5 files changed

+4
-422
lines changed

5 files changed

+4
-422
lines changed

test/Conversion/intel/tritongpu_to_gen.mlir

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,8 @@ module attributes {"ttg.num-ctas" = 1 : i32, "ttg.num-warps" = 4 : i32} {
623623
// CHECK-NEXT: llvm.mlir.constant(1 : i32) : i32
624624
// CHECK-NEXT: llvm.mlir.constant(32 : i32) : i32
625625
// CHECK-NEXT: llvm.mlir.constant(512 : i32) : i32
626+
// CHECK-NEXT: llvm.add
627+
// CHECK-NEXT: llvm.add
626628
// CHECK-NEXT: llvm.mlir.constant(0 : i32) : i32
627629
// CHECK-NEXT: llvm.mul
628630
// CHECK-NEXT: llvm.add

third_party/intel/lib/TritonIntelGPUToLLVM/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ add_triton_library(TritonIntelGPUToLLVM
2424
TypeConverter.cpp
2525
UpcastMXFPToLLVM.cpp
2626
Utility.cpp
27-
ViewOpToLLVM.cpp
2827

2928
DEPENDS
3029
TritonIntelGPUConversionPassIncGen

third_party/intel/lib/TritonIntelGPUToLLVM/PatternTritonGPUOpToLLVM.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ void populateConvertLayoutOpToLLVMPatterns(LLVMTypeConverter &typeConverter,
2929
RewritePatternSet &patterns,
3030
PatternBenefit benefit);
3131

32-
void populateViewOpToLLVMPatterns(LLVMTypeConverter &typeConverter,
33-
RewritePatternSet &patterns,
34-
PatternBenefit benefit);
35-
3632
void populateDotOpToLLVMPatterns(
3733
TritonIntelGPUToLLVMTypeConverter &typeConverter,
3834
RewritePatternSet &patterns, PatternBenefit benefit);

third_party/intel/lib/TritonIntelGPUToLLVM/PipelineManager.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,8 @@ class TritonGPUToLLVMPipelineManager {
234234
targetInfo, benefit);
235235
mlir::triton::populateGatherOpToLLVMPatterns(typeConverter, patterns,
236236
targetInfo, benefit);
237-
intel::populateViewOpToLLVMPatterns(typeConverter, patterns, benefit);
237+
mlir::triton::populateViewOpToLLVMPatterns(typeConverter, patterns,
238+
benefit);
238239

239240
intel::populateTensorPtrOpsToLLVMPatterns(typeConverter, patterns,
240241
benefit);

0 commit comments

Comments
 (0)