Skip to content
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
1fc325d
Add test_all_subset_models mode
kwasd Oct 7, 2024
7eb6e85
Add test_all_subset_models mode
kwasd Oct 7, 2024
284bf46
Update .github/workflows/e2e-performance.yml
kwasd Oct 7, 2024
c47a9f8
Update .github/workflows/e2e-accuracy.yml
kwasd Oct 7, 2024
151e282
Merge https://github.com/intel/intel-xpu-backend-for-triton into feat…
kwasd Oct 8, 2024
312d793
Merge branch 'feature/2246-e2e-accuracy-subset' of https://github.com…
kwasd Oct 8, 2024
1818779
Check models
kwasd Oct 8, 2024
3122341
fix whitespace
kwasd Oct 8, 2024
da4183b
Merge branch 'main' into feature/2246-e2e-accuracy-subset
kwasd Oct 21, 2024
c43be77
check-inductor-report.py
kwasd Oct 21, 2024
78a156f
check-inductor-report.py
kwasd Oct 21, 2024
bbfd22b
check-inductor-report.py
kwasd Oct 21, 2024
4a96f07
check-inductor-report.py
kwasd Oct 21, 2024
eea69a3
check-inductor-report.py
kwasd Oct 21, 2024
c749d14
check-inductor-report.py
kwasd Oct 21, 2024
92f5d63
check-inductor-report.py
kwasd Oct 21, 2024
4ef86fe
Merge branch 'main' into feature/2246-e2e-accuracy-subset
kwasd Oct 21, 2024
da66237
check-inductor-report.py
kwasd Oct 21, 2024
d644e75
check-inductor-report.py
kwasd Oct 21, 2024
06db6d3
check-inductor-report.py
kwasd Oct 21, 2024
e5c6af7
check-inductor-report.py
kwasd Oct 21, 2024
5192b85
check-inductor-report.py
kwasd Oct 21, 2024
b148c40
check-inductor-report.py
kwasd Oct 21, 2024
3679715
check-inductor-report.py
kwasd Oct 21, 2024
543cdd1
check-inductor-report.py
kwasd Oct 21, 2024
76b3ece
check-inductor-report.py
kwasd Oct 21, 2024
8794950
check-inductor-report.py
kwasd Oct 21, 2024
fe5f9f1
check-inductor-report.py
kwasd Oct 21, 2024
0d19d9d
check-inductor-report.py
kwasd Oct 21, 2024
8285df5
check-inductor-report.py
kwasd Oct 21, 2024
cd3dacd
check-inductor-report.py
kwasd Oct 21, 2024
6dfbaee
check-inductor-report.py
kwasd Oct 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/e2e-accuracy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ on:
- all
- subset
default: all
test_all_subset_models:
description: In "subset" mode, do not fail workflow if one of models failed
type: boolean
default: false
only_one_model:
description: Run only this one model
type: string
Expand Down Expand Up @@ -125,6 +129,7 @@ jobs:
test_mode: accuracy
dtype: ${{ matrix.dtype }}
models: ${{ inputs.models }}
test_all_subset_models: ${{ inputs.test_all_subset_models || false }}
only_one_model: ${{ inputs.only_one_model }}
runner_label: ${{ inputs.runner_label }}
TORCH_COMPILE_DEBUG: ${{ inputs.TORCH_COMPILE_DEBUG }}
5 changes: 5 additions & 0 deletions .github/workflows/e2e-performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ on:
- all
- subset
default: subset
test_all_subset_models:
description: In "subset" mode, do not fail workflow if one of models failed
type: boolean
default: false
only_one_model:
description: Run only this one model
type: string
Expand Down Expand Up @@ -136,6 +140,7 @@ jobs:
test_mode: performance
dtype: ${{ matrix.dtype }}
models: ${{ inputs.models }}
test_all_subset_models: ${{ inputs.test_all_subset_models || false }}
only_one_model: ${{ inputs.only_one_model }}
runner_label: ${{ inputs.runner_label }}
TORCH_COMPILE_DEBUG: ${{ inputs.TORCH_COMPILE_DEBUG }}
5 changes: 5 additions & 0 deletions .github/workflows/e2e-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ on:
description: Run all models or a subset
type: string
default: all
test_all_subset_models:
description: In "subset" mode, do not fail workflow if one of models failed
type: boolean
default: false
only_one_model:
description: Run only this one model
type: string
Expand Down Expand Up @@ -226,6 +230,7 @@ jobs:
elif [[ "${{ inputs.models }}" == "subset" ]]; then
while read model; do
bash -e $GITHUB_WORKSPACE/scripts/inductor_xpu_test.sh ${{ inputs.suite }} ${{ inputs.dtype }} ${{ inputs.mode }} ${{ inputs.test_mode }} xpu 0 static 1 0 $model
grep ,$model, $WORKSPACE/inductor_log/*/*/*.csv | grep -q ,pass, || ${{ inputs.test_all_subset_models }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work only for accuracy. Also for accuracy it is possible that CSV file does not exist (major failure with E2E) in this case the one liner above won't work. I think you need more sophisticated script to handle accuracy/performance and all corner cases. The idea is you need to check that every model from the subset was successfully executed.

done < $GITHUB_WORKSPACE/.github/models/performance/${{ inputs.suite }}.txt
else
bash -e $GITHUB_WORKSPACE/scripts/inductor_xpu_test.sh ${{ inputs.suite }} ${{ inputs.dtype }} ${{ inputs.mode }} ${{ inputs.test_mode }} xpu 0 static 1 0
Expand Down