[Draft] Update the fast math pass #2507
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
Since there are UTs failure, IMO it makes sense to guard this change under autotune option first, and create an issue to further investigate.
Comment on lines
+221
to
+224
| for (auto &func : *mod) { | ||
| for (auto &bb : func) { | ||
| for (auto &inst : bb) { | ||
| if (auto *op = dyn_cast<FPMathOperator>(&inst)) { |
Contributor
There was a problem hiding this comment.
use a walker on FPMathOperator?
| context.loadAllAvailableDialects(); | ||
| }); | ||
|
|
||
| // May do this after llvm ir according to user fmath flag. |
Contributor
There was a problem hiding this comment.
Since this PR moves it to LLVMIR, we can remove this comment.
Contributor
Author
|
Can we close this PR? @whitneywhtsang |
Contributor
Sure, we can reopen or create a new PR if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set fast math to the LLVM IR.