From 9a5b4459c0d06e630dadbede4600b63656e66a74 Mon Sep 17 00:00:00 2001 From: "Tiotto, Ettore" Date: Thu, 24 Oct 2024 15:59:45 +0000 Subject: [PATCH 1/3] Remove layout_conversion(1st) from optimization pipeline Signed-off-by: Tiotto, Ettore --- third_party/intel/backend/compiler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/intel/backend/compiler.py b/third_party/intel/backend/compiler.py index 86948112b9..482f02dc87 100644 --- a/third_party/intel/backend/compiler.py +++ b/third_party/intel/backend/compiler.py @@ -233,7 +233,7 @@ def make_ttgir(mod, metadata, opt, properties): passes.ttir.add_convert_to_ttgpuir(pm, "xpu", opt.num_warps, opt.threads_per_warp, opt.num_ctas) intel.passes.ttgpuir.add_accelerate_matmul(pm) - intel.passes.ttgpuir.add_remove_layout_conversions(pm) +## intel.passes.ttgpuir.add_remove_layout_conversions(pm) intel.passes.ttgpuir.add_materialize_block_pointer(pm) intel.passes.ttgpuir.add_rewrite_tensor_pointer(pm) intel.passes.ttgpuir.add_pipeline(pm, opt.num_stages, False) From a7b63cd481626764e3319b22205027a67934a8e8 Mon Sep 17 00:00:00 2001 From: "Tiotto, Ettore" Date: Thu, 24 Oct 2024 16:00:23 +0000 Subject: [PATCH 2/3] Fix pre_commit Signed-off-by: Tiotto, Ettore --- third_party/intel/backend/compiler.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third_party/intel/backend/compiler.py b/third_party/intel/backend/compiler.py index 482f02dc87..b10bb7d450 100644 --- a/third_party/intel/backend/compiler.py +++ b/third_party/intel/backend/compiler.py @@ -233,7 +233,7 @@ def make_ttgir(mod, metadata, opt, properties): passes.ttir.add_convert_to_ttgpuir(pm, "xpu", opt.num_warps, opt.threads_per_warp, opt.num_ctas) intel.passes.ttgpuir.add_accelerate_matmul(pm) -## intel.passes.ttgpuir.add_remove_layout_conversions(pm) + ## intel.passes.ttgpuir.add_remove_layout_conversions(pm) intel.passes.ttgpuir.add_materialize_block_pointer(pm) intel.passes.ttgpuir.add_rewrite_tensor_pointer(pm) intel.passes.ttgpuir.add_pipeline(pm, opt.num_stages, False) From e31056a1de0d4299c5685ce5adc87c83046107b6 Mon Sep 17 00:00:00 2001 From: "Tiotto, Ettore" Date: Thu, 24 Oct 2024 17:20:37 +0000 Subject: [PATCH 3/3] Remove streamk-k bmk Signed-off-by: Tiotto, Ettore --- .github/workflows/triton-benchmarks.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/triton-benchmarks.yml b/.github/workflows/triton-benchmarks.yml index ac5735f727..8d975599f4 100644 --- a/.github/workflows/triton-benchmarks.yml +++ b/.github/workflows/triton-benchmarks.yml @@ -180,14 +180,6 @@ jobs: python ../../scripts/build_report.py $REPORTS/matmul-performance-at.csv $REPORTS/gemm-at-triton-report.csv --benchmark gemm-at --compiler triton --param_cols "B,M,K,N" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG python ../../scripts/build_report.py $REPORTS/matmul-performance-at.csv $REPORTS/gemm-at-onednn-report.csv --benchmark gemm-at --compiler onednn --param_cols "B,M,K,N" --tflops_col onednn-TFlops --hbm_col "onednn-GB/s" --tag $TAG - - name: Run Triton GEMM (stream-k) kernel benchmark - if: ${{ steps.install.outcome == 'success' && !cancelled() }} - run: | - cd benchmarks/triton_kernels_benchmark - python gemm_streamk_benchmark.py --reports $REPORTS - source ../../scripts/capture-hw-details.sh - python ../../scripts/build_report.py $REPORTS/matmul-streamk-performance.csv $REPORTS/gemm-streamk-triton-report.csv --benchmark gemm-streamk --compiler triton --param_cols "M,K,N" --tflops_col Triton-TFlops --hbm_col "Triton-GB/s" --tag $TAG - - name: Run Triton GEMM (split-k) kernel benchmark if: ${{ steps.install.outcome == 'success' && !cancelled() }} run: |