Fix assertion error on gemm_splitk_benchmark.py #2717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonling-ll
requested review from
anmyachev,
chengjunlu,
etiotto,
whitneywhtsang and
yudongsi
anmyachev
reviewed
Nov 15, 2024
| [512, 32768, 8192], | ||
| [1024, 28672, 8192], | ||
| [3072, 4096, 3072], | ||
| [4096, 4096, 4096], |
Contributor
There was a problem hiding this comment.
Adding a new combination breaks the CI and seems a bit out of topic for this pull request. Maybe we should move this change to a separate pull request?
Contributor
There was a problem hiding this comment.
Agree. Split that change in a separate PR please @LiyangLingIntel
Contributor
There was a problem hiding this comment.
I disagree, as this PR supposes to fix the 4k functional error.
Contributor
Author
There was a problem hiding this comment.
I've added 4k shape to XeTLA splitk list, benchmark CI works now.
etiotto
approved these changes
Nov 15, 2024
| [512, 32768, 8192], | ||
| [1024, 28672, 8192], | ||
| [3072, 4096, 3072], | ||
| [4096, 4096, 4096], |
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
please add gemm_splitk_shape_4096_4096_4096 to XeTLA to fix the CI failure.
chengjunlu
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of this error is that we should initialize the results tensor when using
atomic_add, otherwise it would read dirty memory from previous benchmarking cases.