Allow different Microsoft products for the search of VC.Tools.x86.x64
#2744
Conversation
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
|
What if instead of VS i have only VS BuildTools? |
|
|
||
|
|
||
| def set_env_vars(vs_path, arch="x64"): | ||
| vcvarsall_path = Path(vs_path) / "VC" / "Auxiliary" / "Build" / "vcvarsall.bat" |
There was a problem hiding this comment.
The case when vs_path is None is not handled.
There was a problem hiding this comment.
this will be processed at a higher level: https://github.com/intel/intel-xpu-backend-for-triton/pull/2478/files#r1848201018
This most likely won't work, see #2478 (comment) for details. UPD: I saw that the CI doesn't work, now I'll try to fix it here UPD2: with |
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
| ] | ||
|
|
||
|
|
||
| def find_vswhere(): |
There was a problem hiding this comment.
As of now we don't know how to reuse the code from CLFinder.py. See https://github.com/intel/intel-xpu-backend-for-triton/pull/2478/files#r1831953188 for details.
|
@pbchekin ready for review |
anmyachev
changed the title
VC.Tools.x86.x64
|
Blocked by #2743 |
Signed-off-by: Anatoly Myachev <[email protected]>
Part of #2478 (to reduce diff).These are quite stable changes, we can merge it without CI on Windows. @gshimansky if you don't mind.