[UT] Fix test_precise_math
#2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbchekin
approved these changes
Nov 20, 2024
victor-eds
reviewed
Nov 21, 2024
Contributor
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
I may be missing some context (can you add PR description, please?), but I see our test is indeed failing and we are playing tricks to get it to pass. Would llvm/llvm-project#88222 (comment) fix the test without needing to change it?
Contributor
Author
Added PR description.
That is a different issue, we currently need to use cpu result as reference, or else we are comparing with the imprecise result. |
victor-eds
reviewed
Nov 21, 2024
etiotto
approved these changes
Nov 21, 2024
third_party/intel/lib/TritonIntelGPUToLLVM/ElementwiseOpToLLVM.cpp
Outdated
Show resolved
Hide resolved
victor-eds
approved these changes
Nov 22, 2024
Contributor
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
LGTM keeping as is after offline conversation
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
force-pushed
the
whitneywhtsang/sqrt_rn
branch
from
f50c16a to
fc59ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, precise sqrt is lowered to
__imf_sqrtf, which is not precise.__imf_sqrt_rnis added in the new device library updated in #2774.This PR uses
__imf_sqrt_rnto get the precise sqrt implemented.