[Merge] Reland d36e579 from upstream. #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please fix the UT failures. |
chengjunlu
commented
Nov 22, 2024
| if (auto sliceLayout = mlir::dyn_cast<SliceEncodingAttr>(layout)) { | ||
| threadsPerWarp = getThreadsPerWarp(sliceLayout.getParent()); | ||
| threadsPerWarp.erase(threadsPerWarp.begin() + sliceLayout.getDim()); | ||
| warpsPerCTA = getWarpsPerCTA(sliceLayout.getParent()); |
Contributor
Author
There was a problem hiding this comment.
This is a real bug of the upstream. But the NV and AMD code doesn't uses this legacy layout function.
Need to align our lowering code to the upstream once we enabled the LL for DPAS related layout.
Contributor
There was a problem hiding this comment.
Please create an issue to track this.
chengjunlu
force-pushed
the
chengjun/reland_d36e579
branch
2 times, most recently
from
5ea8ec8 to
9a0e517
Compare
whitneywhtsang
approved these changes
Nov 22, 2024
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
Please do not squash and merge.
…erface in DPAS layout.
whitneywhtsang
force-pushed
the
chengjun/reland_d36e579
branch
from
9a0e517 to
1aebd43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland d36e579 that is temporarily reverted in #2783 by 016ee00.
The PR based on PR #2766