Don't use dyn_cast_or_null in DecomposeUnsupportedConversions.cpp
#2836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
FYI, the change is added intentionally in f9b052e for flash attention on advanced path.
Contributor
Author
Thanks! Do you remember the reason for the change in this particular place? |
Contributor
|
Advanced path uses layout differently, and it is possible that |
Contributor
Author
|
It's interesting that all the tests work. |
Contributor
There is no unit tests that run advanced path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark CI: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12039749786 (failed)