Skip to content

[XPU] Enable reduction optimization by default #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
victor-eds wants to merge 5 commits into from
Closed

[XPU] Enable reduction optimization by default #2846

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35174a6
[XPU] Enable reduction optimization by default
victor-eds Nov 27, 2024
7d84fae
Add flag
victor-eds Nov 27, 2024
13a17df
Update triton-benchmarks.yml
victor-eds Nov 27, 2024
b86eff1
Merge branch 'main' into victor/enable-reduction-optimization
victor-eds Nov 27, 2024
4aac45a
Merge branch 'main' into victor/enable-reduction-optimization
victor-eds Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions third_party/intel/backend/compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,7 @@ def make_ttgir(mod, metadata, opt, properties):
passes.common.add_cse(pm)
passes.ttgpuir.add_prefetch(pm)
passes.ttgpuir.add_optimize_dot_operands(pm, True)
if os.getenv("TRITON_INTEL_OPTIMIZE_REDUCTION_LOCALITY", "0") == "1":
intel.passes.ttgpuir.add_optimize_reduction_locality(pm)
intel.passes.ttgpuir.add_optimize_elementwise_parallelism(pm)
intel.passes.ttgpuir.add_optimize_reduction_locality(pm)
Copy link
Contributor

@chengjunlu chengjunlu Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use if os.getenv("TRITON_INTEL_OPTIMIZE_REDUCTION_LOCALITY", "1") == "1": to allow the user to disable it?

Copy link
Contributor Author

@victor-eds victor-eds Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. I'll add that when I finish the investigation

intel.passes.ttgpuir.add_remove_layout_conversions(pm)
intel.passes.ttgpuir.add_reduce_data_duplication(pm)
passes.ttgpuir.add_reorder_instructions(pm)
Expand Down