Skip to content

Update integer literals for PyArg_ParseTuple #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Update integer literals for PyArg_ParseTuple #2938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bef565b
Update integer literals for 'PyArg_ParseTuple'
anmyachev Dec 5, 2024
e4d3d56
revert change for int32_t
anmyachev Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/triton_kernels_benchmark/benchmark_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def format_of(ty):
"int8_t": "b",
"int16_t": "h",
"int32_t": "i",
"int64_t": "l",
"int64_t": "L",
Copy link
Contributor Author

@anmyachev anmyachev Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From python docs:

L ([int](https://docs.python.org/3/library/functions.html#int)) [long long]
Convert a Python integer to a C long long.

L ~ long long int at least 64 bits

"uint8_t": "B",
"uint16_t": "H",
"uint32_t": "I",
Expand Down
2 changes: 1 addition & 1 deletion third_party/amd/backend/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def format_of(ty):
"int8_t": "b",
"int16_t": "h",
"int32_t": "i",
"int64_t": "l",
"int64_t": "L",
Copy link
Contributor Author

@anmyachev anmyachev Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corresponding change in the upstream: triton-lang/triton@390e27f

"uint8_t": "B",
"uint16_t": "H",
"uint32_t": "I",
Expand Down