Reuse compile_module_from_src func in benchmark_driver.py
#3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
commented
Dec 20, 2024
|
|
||
|
|
||
| compilation_helper = CompilationHelper() | ||
| COMPILATION_HELPER = CompilationHelper() |
Contributor
Author
There was a problem hiding this comment.
To mark that the variable is global
Contributor
Author
|
@whitneywhtsang CI is green, please take a look |
whitneywhtsang
approved these changes
Dec 21, 2024
Contributor
|
@anmyachev Please resolve the merge conflict. |
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
force-pushed
the
amyachev/reuse-code
branch
from
524d51c to
777f3ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2540