Skip to content

Adjust LIT tests for the swizzling path #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2025
Merged

Adjust LIT tests for the swizzling path #4910

merged 4 commits into from
Aug 22, 2025

Conversation

wdziurdz
Copy link
Contributor

Fixes #4887
Revert 4809815 , 0d2fd2d and adjust LIT tests accordingly.

The following tests have been updated:

TRITON :: Conversion/intel/tritongpu_to_gen.mlir
TRITON :: Conversion/intel/dpas_to_block_layout_convert.mlir

@wdziurdz wdziurdz mentioned this pull request Aug 18, 2025
Closed
@whitneywhtsang
Copy link
Contributor

There 71 unit test failures, please fix those as well.

@wdziurdz wdziurdz force-pushed the dev/wdziurdz/swizzling-path-2 branch 3 times, most recently from 4e59edf to d5ac9d0 Compare August 21, 2025 12:07
@wdziurdz
Copy link
Contributor Author

wdziurdz commented Aug 21, 2025 •
edited
Loading

Could you please looks on last commit @whitneywhtsang @etiotto ? Previously, the swizzling path truncated i8 -> i1, discarding any set bits other than the low bit (e.g., 0x02 -> false). It now uses icmp_ne(v, 0) to canonicalize booleans, applied only to i1 values.

whitneywhtsang
whitneywhtsang reviewed Aug 21, 2025
View reviewed changes
@whitneywhtsang
Copy link
Contributor

Could you please looks on last commit @whitneywhtsang @etiotto ? Previously, the swizzling path truncated i8 -> i1, discarding any set bits other than the low bit (e.g., 0x02 -> false). It now uses icmp_ne(v, 0) to canonicalize booleans, applied only to i1 values.

Make sense to me, can you try to upstream this portion of the change?

@whitneywhtsang whitneywhtsang force-pushed the dev/wdziurdz/swizzling-path-2 branch from d5ac9d0 to 71f8240 Compare August 21, 2025 19:05
@whitneywhtsang whitneywhtsang force-pushed the dev/wdziurdz/swizzling-path-2 branch from 71f8240 to b6025b4 Compare August 21, 2025 23:42
@whitneywhtsang whitneywhtsang merged commit 28f406e into main Aug 22, 2025
23 of 26 checks passed
@whitneywhtsang whitneywhtsang deleted the dev/wdziurdz/swizzling-path-2 branch August 22, 2025 05:46
@wdziurdz
Copy link
Contributor Author

Could you please looks on last commit @whitneywhtsang @etiotto ? Previously, the swizzling path truncated i8 -> i1, discarding any set bits other than the low bit (e.g., 0x02 -> false). It now uses icmp_ne(v, 0) to canonicalize booleans, applied only to i1 values.

Make sense to me, can you try to upstream this portion of the change?

PR to upstream : triton-lang/triton#7943
and issue: triton-lang/triton#7941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix test failures for the swizzling path
2 participants
@wdziurdz @whitneywhtsang