Skip to content

Fix clang error: add explicit braces to avoid dangling else #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

Fix clang error: add explicit braces to avoid dangling else #5301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions third_party/intel/lib/TritonIntelGPUToLLVM/LoadStoreOpToLLVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,7 +2028,7 @@ struct LoadOpToBlockIOConversion
Value other = op.getOther();
Value llOther = adaptor.getOther();
DenseElementsAttr constAttr;
if (other)
if (other) {
if (matchPattern(other, m_Constant(&constAttr)) && constAttr.isSplat()) {
Type elemTy = constAttr.getElementType();
auto handleSplatValue = [&](auto splatVal) {
Expand All @@ -2049,6 +2049,7 @@ struct LoadOpToBlockIOConversion
} else {
otherElems = unpackLLElements(loc, llOther, rewriter);
}
}

// re-arrange the ptrs and masks to for large 2D block IO.
// Layout is unrelated to the scalar type.
Expand Down Expand Up @@ -2562,7 +2563,7 @@ struct LoadOpToBlockIOConversion
SmallVector<Value> otherElems;
Value llOther = adaptor.getOther();
DenseElementsAttr constAttr;
if (other)
if (other) {
if (matchPattern(other, m_Constant(&constAttr)) && constAttr.isSplat()) {
Type elemTy = constAttr.getElementType();
auto handleSplatValue = [&](auto splatVal) {
Expand All @@ -2583,6 +2584,7 @@ struct LoadOpToBlockIOConversion
} else {
otherElems = unpackLLElements(loc, llOther, rewriter);
}
}

unsigned threadsPerWarp =
TritonGPUDialect::getThreadsPerWarp(op->getParentOfType<ModuleOp>());
Expand Down
Loading