Skip to content

Reland upstream commit 9b75018 #5594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whitneywhtsang merged 2 commits into from
Dec 8, 2025
Merged

Reland upstream commit 9b75018 #5594

whitneywhtsang merged 2 commits into from
Dec 8, 2025

Conversation

@slawblauciak
Copy link
Contributor

@slawblauciak slawblauciak commented Dec 2, 2025

#5527

Adds matching change to Intel's backend.

@slawblauciak slawblauciak mentioned this pull request Dec 2, 2025
Closed
@slawblauciak slawblauciak force-pushed the dev/slbl/cherrypick-upstream-9b75018 branch from 2538821 to 11ddb26 Compare December 2, 2025 11:37
@slawblauciak
Copy link
Contributor Author

slawblauciak commented Dec 2, 2025 •
edited
Loading

Failures are unrelated to the change:

  • Test with pip
  • Test with pip on Windows

I can reproduce the following locally without the changes (commit d415da6):

ERROR:
pytest-skip: Not all tests to skip exist.
Missing test names to skip:
  - python/test/unit/language/test_core.py::test_dot3d[8-1-32-32-32-32-32-float64-float64]
  - python/test/unit/language/test_core.py::test_dot3d[4-1-64-64-64-32-32-float64-float64]

anmyachev
anmyachev reviewed Dec 2, 2025
View reviewed changes
whitneywhtsang
whitneywhtsang reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional comments from me

lezcano and others added 2 commits December 8, 2025 13:09
@lezcano @slawblauciak
[BACKEND] Emit reqnctapercluster (#8645)
ea337e0 
We now tell LLVM and PTXAS the number of CTAs we are about to use.
This allows them to generate better code in most cases.

We also clean-up all the remaining uses of `cluster_dims` and we replace
them by queries to `num_ctas`.
@slawblauciak
Remove cluster_dims references from Intel's backend to match upstream
16e01f8
@slawblauciak slawblauciak force-pushed the dev/slbl/cherrypick-upstream-9b75018 branch from 11ddb26 to 16e01f8 Compare December 8, 2025 13:12
whitneywhtsang
whitneywhtsang approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not squash and merge.

@whitneywhtsang whitneywhtsang merged commit efd7b71 into main Dec 8, 2025
25 of 27 checks passed
@whitneywhtsang whitneywhtsang deleted the dev/slbl/cherrypick-upstream-9b75018 branch December 8, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmyachev anmyachev anmyachev approved these changes

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

@vlad-penkin vlad-penkin Awaiting requested review from vlad-penkin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slawblauciak @anmyachev @whitneywhtsang @lezcano