build: Remove unneeded file types.h

gbtucker · gbtucker · commit 112dd72c01a2 · 2021-06-10T09:35:43.000-07:00
The file types.h has long been misnamed and overlaps with
functionality in the test helper routines.

Change-Id: I774047d3a0074198b67a6b4e909f1e2ce1938195
Signed-off-by: Greg Tucker &lt;greg.b.tucker@intel.com&gt;
diff --git a/Doxyfile b/Doxyfile
@@ -17,7 +17,7 @@ INPUT                  = isa-l.h \
 			 doc/test.md \
 			 doc/build.md
 
-EXCLUDE                = include/test.h include/types.h include/unaligned.h
+EXCLUDE                = include/test.h include/unaligned.h
 EXCLUDE_PATTERNS       = */include/*_multibinary.h
 EXAMPLE_PATH           = . crc raid erasure_code igzip
 PAPER_TYPE             = letter
diff --git a/Makefile.am b/Makefile.am
@@ -3,7 +3,7 @@ CLEANFILES =
 LDADD =
 AM_MAKEFLAGS = --no-print-directory
 noinst_HEADERS =
-pkginclude_HEADERS = include/test.h include/types.h
+pkginclude_HEADERS = include/test.h
 noinst_LTLIBRARIES =
 bin_PROGRAMS =
 INCLUDE = -I $(srcdir)/include/
diff --git a/crc/Makefile.am b/crc/Makefile.am
@@ -72,7 +72,7 @@ lsrc_x86_64 += \
 src_include += -I $(srcdir)/crc
 extern_hdrs +=  include/crc.h include/crc64.h
 
-other_src   +=  include/reg_sizes.asm include/types.h include/test.h \
+other_src   +=  include/reg_sizes.asm include/test.h \
 		crc/crc_ref.h crc/crc64_ref.h
 
 check_tests +=  crc/crc16_t10dif_test \
diff --git a/crc/crc16_t10dif_test.c b/crc/crc16_t10dif_test.c
@@ -32,8 +32,8 @@
 #include <stdint.h>
 #include <stdlib.h>
 #include "crc.h"
-#include "types.h"
 #include "crc_ref.h"
+#include "test.h"
 
 #ifndef TEST_SEED
 # define TEST_SEED 0x1234
diff --git a/crc/crc32_funcs_test.c b/crc/crc32_funcs_test.c
@@ -32,8 +32,8 @@
 #include <string.h>
 #include <stdint.h>
 #include "crc.h"
-#include "types.h"
 #include "crc_ref.h"
+#include "test.h"
 
 #ifndef TEST_SEED
 # define TEST_SEED 0x1234
diff --git a/crc/crc64_funcs_test.c b/crc/crc64_funcs_test.c
@@ -32,8 +32,8 @@
 #include <string.h>
 #include <stdint.h>
 #include "crc64.h"
-#include "types.h"
 #include "crc64_ref.h"
+#include "test.h"
 
 #ifndef TEST_SEED
 # define TEST_SEED 0x1234
diff --git a/erasure_code/Makefile.am b/erasure_code/Makefile.am
@@ -149,5 +149,4 @@ perf_tests   += erasure_code/gf_vect_mul_perf \
 
 other_tests  += erasure_code/gen_rs_matrix_limits
 
-other_src    += include/test.h \
-		include/types.h
+other_src    += include/test.h
diff --git a/erasure_code/erasure_code_base_test.c b/erasure_code/erasure_code_base_test.c
@@ -31,7 +31,7 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_LEN 8192
 #define TEST_SIZE (TEST_LEN/2)
diff --git a/erasure_code/erasure_code_test.c b/erasure_code/erasure_code_test.c
@@ -31,7 +31,7 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_LEN 8192
 #define TEST_SIZE (TEST_LEN/2)
diff --git a/erasure_code/erasure_code_update_perf.c b/erasure_code/erasure_code_update_perf.c
@@ -31,7 +31,6 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
 #include "test.h"
 
 //By default, test multibinary version
diff --git a/erasure_code/erasure_code_update_test.c b/erasure_code/erasure_code_update_test.c
@@ -31,7 +31,7 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
+#include "test.h"
 
 #ifndef ALIGN_SIZE
 # define ALIGN_SIZE 16
diff --git a/erasure_code/gf_vect_dot_prod_base_test.c b/erasure_code/gf_vect_dot_prod_base_test.c
@@ -31,7 +31,7 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_LEN 8192
 #define TEST_SIZE (TEST_LEN/2)
diff --git a/erasure_code/gf_vect_dot_prod_test.c b/erasure_code/gf_vect_dot_prod_test.c
@@ -31,7 +31,7 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
+#include "test.h"
 
 #ifndef FUNCTION_UNDER_TEST
 # define FUNCTION_UNDER_TEST gf_vect_dot_prod
diff --git a/erasure_code/gf_vect_mad_test.c b/erasure_code/gf_vect_mad_test.c
@@ -31,7 +31,7 @@
 #include <stdlib.h>
 #include <string.h>		// for memset, memcmp
 #include "erasure_code.h"
-#include "types.h"
+#include "test.h"
 
 #ifndef ALIGN_SIZE
 # define ALIGN_SIZE 32
diff --git a/igzip/checksum32_funcs_test.c b/igzip/checksum32_funcs_test.c
@@ -33,7 +33,7 @@
 #include <stdint.h>
 #include "igzip_checksums.h"
 #include "checksum_test_ref.h"
-#include "types.h"
+#include "test.h"
 
 #ifndef TEST_SEED
 # define TEST_SEED 0x1234
diff --git a/include/test.h b/include/test.h
@@ -30,6 +30,15 @@
 #ifndef _TEST_H
 #define _TEST_H
 
+/**
+ *  @file  test.h
+ *  @brief Test helper include for common perf and test macros
+ *
+ *  This is a helper file to enable short and simple tests. Not intended for use
+ *  in library functions or production. Includes helper routines for alignment,
+ *  benchmark timing, and filesize.
+ */
+
 #ifdef __cplusplus
 extern "C" {
 #endif
@@ -41,6 +50,29 @@ extern "C" {
 # define inline __inline
 #endif
 
+/* Make os-independent alignment attribute, alloc and free. */
+#if defined  __unix__ || defined __APPLE__
+# define DECLARE_ALIGNED(decl, alignval) decl __attribute__((aligned(alignval)))
+# define __forceinline static inline
+# define aligned_free(x) free(x)
+#else
+# ifdef __MINGW32__
+#   define DECLARE_ALIGNED(decl, alignval) decl __attribute__((aligned(alignval)))
+#   define posix_memalign(p, algn, len) (NULL == (*((char**)(p)) = (void*) _aligned_malloc(len, algn)))
+#   define aligned_free(x) _aligned_free(x)
+# else
+#   define DECLARE_ALIGNED(decl, alignval) __declspec(align(alignval)) decl
+#   define posix_memalign(p, algn, len) (NULL == (*((char**)(p)) = (void*) _aligned_malloc(len, algn)))
+#   define aligned_free(x) _aligned_free(x)
+# endif
+#endif
+
+#ifdef DEBUG
+# define DEBUG_PRINT(x) printf x
+#else
+# define DEBUG_PRINT(x) do {} while (0)
+#endif
+
 /* Decide wether to use benchmark time as an approximation or a minimum. Fewer
  * calls to the timer are required for the approximation case.*/
 #define BENCHMARK_MIN_TIME 0
diff --git a/include/types.h b/include/types.h
diff --git a/make.inc b/make.inc
@@ -333,7 +333,6 @@ install: $(sort $(extern_hdrs)) | $(install_dirs) $(lib_name) $(so_lib_name) isa
 	install -m 644 $(lib_name) $(prefix)/lib/libisal.a
 	install -m 644 $^ $(prefix)/include/isa-l/.
 	install -m 664 isa-l.h $(prefix)/include/.
-	install -m 664 include/types.h $(prefix)/include/isa-l/.
 	install -m 664 $(so_lib_name) $(prefix)/lib/$(so_lib_ver)
 	(cd $(prefix)/lib && ln -f -s $(so_lib_ver) $(soname) && ln -f -s $(so_lib_ver) $(so_lib_inst))
 ifeq ($(shell uname),Darwin)
diff --git a/mem/Makefile.am b/mem/Makefile.am
@@ -40,8 +40,7 @@ lsrc_x86_64 += 	mem/mem_zero_detect_avx.asm \
 
 extern_hdrs +=	include/mem_routines.h
 
-other_src   +=  include/test.h \
-		include/types.h
+other_src   +=  include/test.h
 
 check_tests  +=  mem/mem_zero_detect_test
 
diff --git a/mem/mem_zero_detect_perf.c b/mem/mem_zero_detect_perf.c
@@ -32,7 +32,6 @@
 #include <string.h>
 #include "mem_routines.h"
 #include "test.h"
-#include "types.h"
 
 #define TEST_LEN     8*1024
 #define TEST_TYPE_STR "_warm"
diff --git a/mem/mem_zero_detect_test.c b/mem/mem_zero_detect_test.c
@@ -32,7 +32,7 @@
 #include <stdlib.h>
 #include <limits.h>
 #include "mem_routines.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_MEM  10*1024*1024
 #define TEST_LEN  8*1024
diff --git a/raid/Makefile.am b/raid/Makefile.am
@@ -56,7 +56,7 @@ lsrc_x86_32 += \
 
 extern_hdrs +=	include/raid.h
 
-other_src   +=  include/test.h include/types.h
+other_src   +=  include/test.h
 
 check_tests +=  raid/xor_gen_test raid/pq_gen_test raid/xor_check_test raid/pq_check_test
 
diff --git a/raid/pq_check_test.c b/raid/pq_check_test.c
@@ -32,7 +32,7 @@
 #include<string.h>
 #include<stdlib.h>
 #include "raid.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_SOURCES 16
 #define TEST_LEN     1024
diff --git a/raid/pq_gen_test.c b/raid/pq_gen_test.c
@@ -33,7 +33,7 @@
 #include<stdlib.h>
 #include<limits.h>
 #include "raid.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_SOURCES 16
 #define TEST_LEN     1024
diff --git a/raid/xor_check_test.c b/raid/xor_check_test.c
@@ -32,7 +32,7 @@
 #include<string.h>
 #include<stdlib.h>
 #include "raid.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_SOURCES 16
 #define TEST_LEN     1024
diff --git a/raid/xor_example.c b/raid/xor_example.c
@@ -29,7 +29,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include "raid.h"
-#include "types.h"
 
 #define TEST_SOURCES 16
 #define TEST_LEN     16*1024
diff --git a/raid/xor_gen_test.c b/raid/xor_gen_test.c
@@ -32,7 +32,7 @@
 #include<string.h>
 #include<stdlib.h>
 #include "raid.h"
-#include "types.h"
+#include "test.h"
 
 #define TEST_SOURCES 16
 #define TEST_LEN     1024
