Skip to content

Commit c83771e

Browse files
pablodelaratkanteck
authored andcommitted
mem: [test] fix memory leak
Signed-off-by: Pablo de Lara <[email protected]>
1 parent a3e2604 commit c83771e

File tree

1 file changed

+25
-15
lines changed

1 file changed

+25
-15
lines changed

mem/mem_zero_detect_test.c

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ int main(int argc, char *argv[])
5050
{
5151
int i, j, sign;
5252
long long r, l;
53-
void *buf;
53+
void *buf = NULL;
5454
unsigned char *a;
5555
int failures = 0, ret_neg = 1;
5656

@@ -69,7 +69,7 @@ int main(int argc, char *argv[])
6969

7070
if (failures) {
7171
printf("Fail large buf test\n");
72-
return failures;
72+
goto exit;
7373
}
7474
#ifdef TEST_VERBOSE
7575
putchar('.');
@@ -83,7 +83,7 @@ int main(int argc, char *argv[])
8383
if (failures) {
8484
printf("Fail alloc test\n");
8585
free(newbuf);
86-
return failures;
86+
goto exit;
8787
}
8888
free(newbuf);
8989
}
@@ -93,7 +93,7 @@ int main(int argc, char *argv[])
9393
failures |= isal_zero_detect(buf, i);
9494
if (failures) {
9595
printf("Fail len=%d\n", i);
96-
return failures;
96+
goto exit;
9797
}
9898
}
9999
#ifdef TEST_VERBOSE
@@ -107,7 +107,7 @@ int main(int argc, char *argv[])
107107

108108
if (failures) {
109109
printf("Fail:\n");
110-
return failures;
110+
goto exit;
111111
}
112112
#ifdef TEST_VERBOSE
113113
putchar('.');
@@ -118,7 +118,8 @@ int main(int argc, char *argv[])
118118
ret_neg = isal_zero_detect(a, TEST_MEM);
119119
if (ret_neg == 0) {
120120
printf("Fail on not detect\n");
121-
return -1;
121+
failures = -1;
122+
goto exit;
122123
}
123124
a[TEST_MEM / 2] = 0;
124125
#ifdef TEST_VERBOSE
@@ -132,7 +133,8 @@ int main(int argc, char *argv[])
132133
ret_neg = isal_zero_detect(a, TEST_MEM);
133134
if (ret_neg == 0) {
134135
printf("Fail on not detect offsets %d, %d\n", i, j);
135-
return -1;
136+
failures = -1;
137+
goto exit;
136138
}
137139
a[i] = 0;
138140
}
@@ -153,7 +155,8 @@ int main(int argc, char *argv[])
153155
ret_neg = isal_zero_detect(a, TEST_MEM);
154156
if (ret_neg == 0) {
155157
printf("Fail on not detect rand %d, e=%lld\n", i, r);
156-
return -1;
158+
failures = -1;
159+
goto exit;
157160
}
158161
a[r] = 0;
159162
}
@@ -169,7 +172,8 @@ int main(int argc, char *argv[])
169172
ret_neg = isal_zero_detect(a, TEST_MEM);
170173
if (ret_neg == 0) {
171174
printf("Fail on not detect rand offset=%d, idx=%d\n", i, j);
172-
return -1;
175+
failures = -1;
176+
goto exit;
173177
}
174178
a[TEST_MEM - i] = 0;
175179
}
@@ -185,19 +189,21 @@ int main(int argc, char *argv[])
185189

186190
if (failures) {
187191
printf("Fail on detect non-zero with l=%lld\n", l);
188-
return -1;
192+
goto exit;
189193
}
190194

191195
a[i] = 1;
192196
ret_neg = isal_zero_detect(a, l);
193197

194198
if ((i < l) && (ret_neg == 0)) {
195199
printf("Fail on non-zero buffer l=%lld err=%d\n", l, i);
196-
return -1;
200+
failures = -1;
201+
goto exit;
197202
}
198203
if ((i >= l) && (ret_neg != 0)) {
199204
printf("Fail on bad pass detect l=%lld err=%d\n", l, i);
200-
return -1;
205+
failures = -1;
206+
goto exit;
201207
}
202208
a[i] = 0;
203209
}
@@ -215,7 +221,8 @@ int main(int argc, char *argv[])
215221
ret_neg = isal_zero_detect(a, l);
216222
if (ret_neg == 0) {
217223
printf("Fail on not detect rand %d, l=%lld, e=%lld\n", i, l, r);
218-
return -1;
224+
failures = -1;
225+
goto exit;
219226
}
220227
a[r] = 0;
221228
}
@@ -239,12 +246,14 @@ int main(int argc, char *argv[])
239246

240247
if ((r < l) && (ret_neg == 0)) {
241248
printf("Fail on non-zero rand buffer %d, l=%lld, e=%lld\n", i, l, r);
242-
return -1;
249+
failures = -1;
250+
goto exit;
243251
}
244252
if ((r >= l) && (ret_neg != 0)) {
245253
printf("Fail on bad pass zero detect rand %d, l=%lld, e=%lld\n", i, l,
246254
r);
247-
return -1;
255+
failures = -1;
256+
goto exit;
248257
}
249258

250259
a[r] = 0;
@@ -254,6 +263,7 @@ int main(int argc, char *argv[])
254263
#endif
255264
fflush(0);
256265

266+
exit:
257267
aligned_free(buf);
258268
printf(failures == 0 ? " Pass\n" : " Fail\n");
259269
return failures;

0 commit comments

Comments
 (0)