Skip to content

Commit e3c2d24

Browse files
ellertpablodelara
authored andcommitted
Address compiler warnings on ppc64le and s390x
igzip/igzip_icf_body.c:7:1: warning: type of 'gen_icf_map_lh1' does not match original declaration [-Wlto-type-mismatch] 7 | gen_icf_map_lh1(struct isal_zstream *, struct deflate_icf *, uint32_t); | ^ igzip/igzip_base_aliases.c:177:1: note: return value type mismatch 177 | gen_icf_map_lh1(struct isal_zstream *stream, struct deflate_icf *matches_icf_lookup, | ^ igzip/igzip_base_aliases.c:177:1: note: type 'void' should match type 'uint64_t' igzip/igzip_base_aliases.c:177:1: note: 'gen_icf_map_lh1' was previously declared here igzip/igzip_base_aliases.c:177:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used igzip/igzip_icf_body.c:9:1: warning: type of 'set_long_icf_fg' does not match original declaration [-Wlto-type-mismatch] 9 | set_long_icf_fg(uint8_t *, uint64_t, uint64_t, struct deflate_icf *); | ^ igzip/igzip_base_aliases.c:170:1: note: type mismatch in parameter 2 170 | set_long_icf_fg(uint8_t *next_in, uint8_t *end_in, struct deflate_icf *match_lookup, | ^ igzip/igzip_base_aliases.c:170:1: note: 'set_long_icf_fg' was previously declared here igzip/igzip_base_aliases.c:170:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used igzip/igzip_base_aliases.c:62:1: warning: type of 'set_long_icf_fg_base' does not match original declaration [-Wlto-type-mismatch] 62 | set_long_icf_fg_base(uint8_t *next_in, uint8_t *end_in, struct deflate_icf *match_lookup, | ^ igzip/igzip_icf_body.c:34:1: note: type mismatch in parameter 2 34 | set_long_icf_fg_base(uint8_t *next_in, uint64_t processed, uint64_t input_size, | ^ igzip/igzip_icf_body.c:34:1: note: 'set_long_icf_fg_base' was previously declared here igzip/igzip_icf_body.c:34:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used igzip/igzip_base_aliases.c:54:1: warning: type of 'adler32_base' does not match original declaration [-Wlto-type-mismatch] 54 | adler32_base(uint32_t init, const unsigned char *buf, uint64_t len); | ^ igzip/adler32_base.c:34:1: note: type mismatch in parameter 3 34 | adler32_base(uint32_t adler32, uint8_t *start, uint32_t length) | ^ igzip/adler32_base.c:34:1: note: type 'uint32_t' should match type 'uint64_t' igzip/adler32_base.c:34:1: note: 'adler32_base' was previously declared here igzip/adler32_base.c:34:1: note: code may be misoptimized unless '-fno-strict-aliasing' is used Signed-off-by: Mattias Ellert <[email protected]>
1 parent c387163 commit e3c2d24

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

igzip/adler32_base.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#include "igzip_checksums.h"
3232

3333
uint32_t
34-
adler32_base(uint32_t adler32, uint8_t *start, uint32_t length)
34+
adler32_base(uint32_t adler32, uint8_t *start, uint64_t length)
3535
{
3636
uint8_t *end, *next = start;
3737
uint64_t A, B;

igzip/igzip_base_aliases.c

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,10 @@ extern void
5959
isal_deflate_hash_base(uint16_t *, uint32_t, uint32_t, uint8_t *, uint32_t);
6060

6161
void
62-
set_long_icf_fg_base(uint8_t *next_in, uint8_t *end_in, struct deflate_icf *match_lookup,
63-
struct level_buf *level_buf);
64-
void
62+
set_long_icf_fg_base(uint8_t *next_in, uint64_t processed, uint64_t input_size,
63+
struct deflate_icf *match_lookup);
64+
65+
uint64_t
6566
gen_icf_map_h1_base(struct isal_zstream *stream, struct deflate_icf *matches_icf_lookup,
6667
uint64_t input_size);
6768

@@ -167,15 +168,15 @@ isal_deflate_hash_lvl3(uint16_t *hash_table, uint32_t hash_mask, uint32_t curren
167168
}
168169

169170
void
170-
set_long_icf_fg(uint8_t *next_in, uint8_t *end_in, struct deflate_icf *match_lookup,
171-
struct level_buf *level_buf)
171+
set_long_icf_fg(uint8_t *next_in, uint64_t processed, uint64_t input_size,
172+
struct deflate_icf *match_lookup)
172173
{
173-
set_long_icf_fg_base(next_in, end_in, match_lookup, level_buf);
174+
set_long_icf_fg_base(next_in, processed, input_size, match_lookup);
174175
}
175176

176-
void
177+
uint64_t
177178
gen_icf_map_lh1(struct isal_zstream *stream, struct deflate_icf *matches_icf_lookup,
178179
uint64_t input_size)
179180
{
180-
gen_icf_map_h1_base(stream, matches_icf_lookup, input_size);
181+
return gen_icf_map_h1_base(stream, matches_icf_lookup, input_size);
181182
}

igzip/igzip_icf_body.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include "igzip_level_buf_structs.h"
55

66
extern uint64_t
7-
gen_icf_map_lh1(struct isal_zstream *, struct deflate_icf *, uint32_t);
7+
gen_icf_map_lh1(struct isal_zstream *, struct deflate_icf *, uint64_t);
88
extern void
99
set_long_icf_fg(uint8_t *, uint64_t, uint64_t, struct deflate_icf *);
1010
extern void

0 commit comments

Comments
 (0)